Changeset 46577995 in mainline for uspace/lib/drv/generic/remote_ahci.c

Timestamp:

2018-01-04T20:50:52Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

e211ea04

Parents:

facacc71

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:47:53)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:50:52)

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

After this commit, HelenOS is free of code that mixes error codes with non-error
values on the assumption that error codes are negative.

File:

• uspace/lib/drv/generic/remote_ahci.c (modified) (16 diffs)

uspace/lib/drv/generic/remote_ahci.c

@@ -65 +65 @@
         
         char devn[MAX_NAME_LENGTH];
-        int rc = devman_fun_get_name(funh, devn, MAX_NAME_LENGTH);
+        errno_t rc = devman_fun_get_name(funh, devn, MAX_NAME_LENGTH);
         if (rc != EOK)
                 return NULL;
@@ -83 +83 @@
 }
 
-int ahci_get_sata_device_name(async_sess_t *sess, size_t sata_dev_name_length,
+errno_t ahci_get_sata_device_name(async_sess_t *sess, size_t sata_dev_name_length,
     char *sata_dev_name)
 {
@@ -95 +95 @@
         async_data_read_start(exch, sata_dev_name, sata_dev_name_length);
         
-        int rc;
+        errno_t rc;
         async_wait_for(req, &rc);
         
@@ -101 +101 @@
 }
 
-int ahci_get_num_blocks(async_sess_t *sess, uint64_t *blocks)
+errno_t ahci_get_num_blocks(async_sess_t *sess, uint64_t *blocks)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -109 +109 @@
         sysarg_t blocks_hi;
         sysarg_t blocks_lo;
-        int rc = async_req_1_2(exch, DEV_IFACE_ID(AHCI_DEV_IFACE),
+        errno_t rc = async_req_1_2(exch, DEV_IFACE_ID(AHCI_DEV_IFACE),
             IPC_M_AHCI_GET_NUM_BLOCKS, &blocks_hi, &blocks_lo);
         
@@ -122 +122 @@
 }
 
-int ahci_get_block_size(async_sess_t *sess, size_t *blocks_size)
+errno_t ahci_get_block_size(async_sess_t *sess, size_t *blocks_size)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -129 +129 @@
         
         sysarg_t bs;
-        int rc = async_req_1_1(exch, DEV_IFACE_ID(AHCI_DEV_IFACE),
+        errno_t rc = async_req_1_1(exch, DEV_IFACE_ID(AHCI_DEV_IFACE),
             IPC_M_AHCI_GET_BLOCK_SIZE, &bs);
         
@@ -140 +140 @@
 }
 
-int ahci_read_blocks(async_sess_t *sess, uint64_t blocknum, size_t count,
+errno_t ahci_read_blocks(async_sess_t *sess, uint64_t blocknum, size_t count,
     void *buf)
 {
@@ -155 +155 @@
         async_exchange_end(exch);
         
-        int rc;
+        errno_t rc;
         async_wait_for(req, &rc);
         
@@ -161 +161 @@
 }
 
-int ahci_write_blocks(async_sess_t *sess, uint64_t blocknum, size_t count,
+errno_t ahci_write_blocks(async_sess_t *sess, uint64_t blocknum, size_t count,
     void* buf)
 {
@@ -175 +175 @@
         async_exchange_end(exch);
         
-        int rc;
+        errno_t rc;
         async_wait_for(req, &rc);
         
@@ -227 +227 @@
         }       
         
-        const int ret = ahci_iface->get_sata_device_name(fun,
+        const errno_t ret = ahci_iface->get_sata_device_name(fun,
             sata_dev_name_length, sata_dev_name);
         
@@ -251 +251 @@
         
         uint64_t blocks;
-        const int ret = ahci_iface->get_num_blocks(fun, &blocks);
+        const errno_t ret = ahci_iface->get_num_blocks(fun, &blocks);
         
         if (ret != EOK)
@@ -270 +270 @@
         
         size_t blocks;
-        const int ret = ahci_iface->get_block_size(fun, &blocks);
+        const errno_t ret = ahci_iface->get_block_size(fun, &blocks);
         
         if (ret != EOK)
@@ -302 +302 @@
         const size_t cnt = (size_t) DEV_IPC_GET_ARG3(*call);
         
-        const int ret = ahci_iface->read_blocks(fun, blocknum, cnt, buf);
+        const errno_t ret = ahci_iface->read_blocks(fun, blocknum, cnt, buf);
         
         async_answer_0(callid, ret);
@@ -331 +331 @@
         const size_t cnt = (size_t) DEV_IPC_GET_ARG3(*call);
         
-        const int ret = ahci_iface->write_blocks(fun, blocknum, cnt, buf);
+        const errno_t ret = ahci_iface->write_blocks(fun, blocknum, cnt, buf);
         
         async_answer_0(callid, ret);