Changeset 46577995 in mainline for uspace/srv/fs/exfat/exfat_fat.c

Timestamp:

2018-01-04T20:50:52Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

e211ea04

Parents:

facacc71

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:47:53)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:50:52)

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

After this commit, HelenOS is free of code that mixes error codes with non-error
values on the assumption that error codes are negative.

File:

• uspace/srv/fs/exfat/exfat_fat.c (modified) (19 diffs)

uspace/srv/fs/exfat/exfat_fat.c

@@ -73 +73 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 exfat_cluster_walk(exfat_bs_t *bs, service_id_t service_id, 
     exfat_cluster_t firstc, exfat_cluster_t *lastc, uint32_t *numc,
@@ -80 +80 @@
         uint32_t clusters = 0;
         exfat_cluster_t clst = firstc;
-        int rc;
+        errno_t rc;
 
         if (firstc < EXFAT_CLST_FIRST) {
@@ -122 +122 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 exfat_block_get(block_t **block, exfat_bs_t *bs, exfat_node_t *nodep,
     aoff64_t bn, int flags)
@@ -129 +129 @@
         exfat_cluster_t currc = 0;
         aoff64_t relbn = bn;
-        int rc;
+        errno_t rc;
 
         if (!nodep->size)
@@ -186 +186 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 exfat_block_get_by_clst(block_t **block, exfat_bs_t *bs, 
     service_id_t service_id, bool fragmented, exfat_cluster_t fcl,
@@ -194 +194 @@
         uint32_t max_clusters;
         exfat_cluster_t c = EXFAT_CLST_FIRST;
-        int rc;
+        errno_t rc;
 
         if (fcl < EXFAT_CLST_FIRST || fcl > DATA_CNT(bs) + 2)
@@ -229 +229 @@
  * @return              EOK or an error code.
  */
-int
+errno_t
 exfat_get_cluster(exfat_bs_t *bs, service_id_t service_id,
     exfat_cluster_t clst, exfat_cluster_t *value)
@@ -235 +235 @@
         block_t *b;
         aoff64_t offset;
-        int rc;
+        errno_t rc;
 
         offset = clst * sizeof(exfat_cluster_t);
@@ -259 +259 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 exfat_set_cluster(exfat_bs_t *bs, service_id_t service_id,
     exfat_cluster_t clst, exfat_cluster_t value)
@@ -265 +265 @@
         block_t *b;
         aoff64_t offset;
-        int rc;
+        errno_t rc;
 
         offset = clst * sizeof(exfat_cluster_t);
@@ -297 +297 @@
  * @return              EOK on success, an error code otherwise.
  */
-int
+errno_t
 exfat_alloc_clusters(exfat_bs_t *bs, service_id_t service_id, unsigned nclsts,
     exfat_cluster_t *mcl, exfat_cluster_t *lcl)
@@ -304 +304 @@
         unsigned found = 0;     /* top of the free cluster number stack */
         exfat_cluster_t clst;
-        int rc = EOK;
+        errno_t rc = EOK;
 
         lifo = (exfat_cluster_t *) malloc(nclsts * sizeof(exfat_cluster_t));
@@ -363 +363 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 exfat_free_clusters(exfat_bs_t *bs, service_id_t service_id, exfat_cluster_t firstc)
 {
         exfat_cluster_t nextc;
-        int rc;
+        errno_t rc;
 
         /* Mark all clusters in the chain as free */
@@ -396 +396 @@
  * @return              EOK on success or an error code.
  */
-int
+errno_t
 exfat_append_clusters(exfat_bs_t *bs, exfat_node_t *nodep, exfat_cluster_t mcl,
     exfat_cluster_t lcl)
@@ -402 +402 @@
         service_id_t service_id = nodep->idx->service_id;
         exfat_cluster_t lastc = 0;
-        int rc;
+        errno_t rc;
 
         if (nodep->firstc == 0) {
@@ -440 +440 @@
  * @return              EOK on success or an error code.
  */
-int exfat_chop_clusters(exfat_bs_t *bs, exfat_node_t *nodep, exfat_cluster_t lcl)
-{
-        int rc;
+errno_t exfat_chop_clusters(exfat_bs_t *bs, exfat_node_t *nodep, exfat_cluster_t lcl)
+{
+        errno_t rc;
         service_id_t service_id = nodep->idx->service_id;
 
@@ -486 +486 @@
 }
 
-int
+errno_t
 exfat_zero_cluster(exfat_bs_t *bs, service_id_t service_id, exfat_cluster_t c)
 {
         size_t i;
         block_t *b;
-        int rc;
+        errno_t rc;
 
         for (i = 0; i < SPC(bs); i++) {
@@ -508 +508 @@
 }
 
-int
+errno_t
 exfat_read_uctable(exfat_bs_t *bs, exfat_node_t *nodep, uint8_t *uctable)
 {
         size_t i, blocks, count;
         block_t *b;
-        int rc;
+        errno_t rc;
         blocks = ROUND_UP(nodep->size, BPS(bs))/BPS(bs);
         count = BPS(bs);
@@ -540 +540 @@
  * does not contain a exfat file system.
  */
-int exfat_sanity_check(exfat_bs_t *bs)
+errno_t exfat_sanity_check(exfat_bs_t *bs)
 {
         if (str_cmp((char const *)bs->oem_name, "EXFAT   "))