Changeset 46b881c in mainline for uspace/srv/hw/netif/ne2000/ne2000.c


Ignore:
Timestamp:
2011-01-29T11:36:41Z (14 years ago)
Author:
Martin Decky <martin@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
0b6931a, 8add9ca5
Parents:
e26a4633 (diff), ffa2c8ef (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.
Message:

IPC/async: strictly isolate the use of low-level IPC methods (ipc_*) and async framework methods (async_*) in user code, do not allow a mixture of both in a single source file

Benefits for future plans

  • The async framework could use different communication style under the hood, but keeping the same high-level API
  • The async framework can be integrated more tightly with sessions without potential problems of intermixing session-aware async methods with session-unaware low-level methods in user code
  • The async_serialize_start()/_end() can be deprecated more easily
File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/srv/hw/netif/ne2000/ne2000.c

    re26a4633 r46b881c  
    4343#include <malloc.h>
    4444#include <sysinfo.h>
    45 #include <ipc/ipc.h>
    4645#include <ipc/services.h>
    4746#include <ipc/ns.h>
     
    317316                ne2k_cmds[5].addr = ne2k->port + DP_TSR;
    318317               
    319                 int rc = ipc_register_irq(ne2k->irq, device->device_id,
     318                int rc = register_irq(ne2k->irq, device->device_id,
    320319                    device->device_id, &ne2k_code);
    321320                if (rc != EOK)
     
    324323                rc = ne2k_up(ne2k);
    325324                if (rc != EOK) {
    326                         ipc_unregister_irq(ne2k->irq, device->device_id);
     325                        unregister_irq(ne2k->irq, device->device_id);
    327326                        return rc;
    328327                }
     
    343342               
    344343                ne2k_down(ne2k);
    345                 ipc_unregister_irq(ne2k->irq, device->device_id);
     344                unregister_irq(ne2k->irq, device->device_id);
    346345                change_state(device, NETIF_STOPPED);
    347346        }
     
    396395        async_set_interrupt_received(irq_handler);
    397396       
    398         return ipc_connect_to_me(PHONE_NS, SERVICE_NE2000, 0, 0, NULL, NULL);
     397        return async_connect_to_me(PHONE_NS, SERVICE_NE2000, 0, 0, NULL);
    399398}
    400399
Note: See TracChangeset for help on using the changeset viewer.