Changeset 4c6fd56 in mainline for uspace/srv/hid/isdv4_tablet/main.c

Timestamp:

2023-09-16T19:58:18Z (16 months ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7d7f5e3

Parents:

6a0b2cc

git-author:

Jiri Svoboda <jiri@…> (2023-09-16 19:48:07)

git-committer:

Jiri Svoboda <jiri@…> (2023-09-16 19:58:18)

Message:

loc_server_register() should be callable more than once (API only)

Now loc_server_register() returns a pointer to a loc_srv_t object,
that is then passed to loc_service_register() and
loc_service_add_to_cat().

Added loc_server_unregister() that unregisters the server
and frees the loc_srv_t object.

Updated all callers. The implementation, however, is a stub.
It is not actually possible to call loc_server_register() more
than once, yet.

File:

• uspace/srv/hid/isdv4_tablet/main.c (modified) (5 diffs)

uspace/srv/hid/isdv4_tablet/main.c

@@ -1 +1 @@
 /*
+ * Copyright (c) 2023 Jiri Svoboda
  * Copyright (c) 2012 Martin Sucha
  * All rights reserved.
@@ -184 +185 @@
         serial_t *serial;
         char *serial_port_name = NULL;
+        loc_srv_t *srv;
 
         int arg = 1;
@@ -315 +317 @@
 
         async_set_fallback_port_handler(mouse_connection, NULL);
-        rc = loc_server_register(NAME);
+        rc = loc_server_register(NAME, &srv);
         if (rc != EOK) {
                 printf("%s: Unable to register driver.\n", NAME);
@@ -329 +331 @@
         }
 
-        rc = loc_service_register(service_name, &service_id);
-        if (rc != EOK) {
+        rc = loc_service_register(srv, service_name, &service_id);
+        if (rc != EOK) {
+                loc_server_unregister(srv);
                 printf(NAME ": Unable to register service %s.\n", service_name);
                 return rc;
@@ -340 +343 @@
                 printf(NAME ": Unable to get mouse category id.\n");
         } else {
-                rc = loc_service_add_to_cat(service_id, mouse_category);
+                rc = loc_service_add_to_cat(srv, service_id, mouse_category);
                 if (rc != EOK) {
                         printf(NAME ": Unable to add device to mouse category.\n");