Changeset 56fd7cf in mainline for uspace/drv/bus/usb/uhcirh/main.c

Timestamp:

2012-08-17T11:37:03Z (12 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1d5a540

Parents:

be2a38ad

Message:

Make ddf_dev_t and ddf_fun_t opaque. This further tighthens the DDF interface.

File:

• uspace/drv/bus/usb/uhcirh/main.c (modified) (6 diffs)

uspace/drv/bus/usb/uhcirh/main.c

@@ -48 +48 @@
 #define NAME "uhcirh"
 
-static int hc_get_my_registers(const ddf_dev_t *dev,
+static int hc_get_my_registers(ddf_dev_t *dev,
     uintptr_t *io_reg_address, size_t *io_reg_size);
 
@@ -88 +88 @@
 
         usb_log_debug2("uhci_rh_dev_add(handle=%" PRIun ")\n",
-            device->handle);
+            ddf_dev_get_handle(device));
 
         uintptr_t io_regs = 0;
@@ -98 +98 @@
 if (ret != EOK) { \
         usb_log_error(message); \
-        if (rh) \
-                free(rh); \
         return ret; \
 } else (void)0
@@ -109 +107 @@
             (void *) io_regs, io_size);
 
-        rh = malloc(sizeof(uhci_root_hub_t));
+        rh = ddf_dev_data_alloc(device, sizeof(uhci_root_hub_t));
         ret = (rh == NULL) ? ENOMEM : EOK;
         CHECK_RET_FREE_RH_RETURN(ret,
@@ -119 +117 @@
             ret, str_error(ret));
 
-        device->driver_data = rh;
         usb_log_info("Controlling root hub '%s' (%" PRIun ").\n",
-            device->name, device->handle);
+            ddf_dev_get_name(device), ddf_dev_get_handle(device));
         return EOK;
 }
@@ -133 +130 @@
  */
 int hc_get_my_registers(
-    const ddf_dev_t *dev, uintptr_t *io_reg_address, size_t *io_reg_size)
+    ddf_dev_t *dev, uintptr_t *io_reg_address, size_t *io_reg_size)
 {
-        assert(dev);
-
         async_sess_t *parent_sess =
-            devman_parent_device_connect(EXCHANGE_SERIALIZE, dev->handle,
-            IPC_FLAG_BLOCKING);
+            devman_parent_device_connect(EXCHANGE_SERIALIZE,
+            ddf_dev_get_handle(dev), IPC_FLAG_BLOCKING);
         if (!parent_sess)
                 return ENOMEM;