Changeset 6caf5fb in mainline for kernel/generic/src/ipc/ipc.c

Timestamp:

2025-01-16T21:42:15Z (20 hours ago)

Author:

GitHub <noreply@…>

Parents:

e0e2264 (diff), 455241b (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2025-01-16 21:42:15)

git-committer:

GitHub <noreply@…> (2025-01-16 21:42:15)

Message:

Merge 455241b37bedd3719ed3b5b025fdf26f44fd565b into e0e22648f5799cc98671695e153b0b00037daeb9

File:

• kernel/generic/src/ipc/ipc.c (modified) (18 diffs)

kernel/generic/src/ipc/ipc.c

@@ -71 +71 @@
 static slab_cache_t *answerbox_cache;
 
+slab_cache_t *irq_cache = NULL;
 slab_cache_t *phone_cache = NULL;
 
@@ -87 +88 @@
         call->callerbox = NULL;
         call->buffer = NULL;
-}
-
-static void call_destroy(void *arg)
-{
-        call_t *call = (call_t *) arg;
+        kobject_initialize(&call->kobject, KOBJECT_TYPE_CALL);
+}
+
+static void call_destroy(kobject_t *arg)
+{
+        call_t *call = call_from_kobject(arg);
 
         if (call->buffer)
                 free(call->buffer);
         if (call->caller_phone)
-                kobject_put(call->caller_phone->kobject);
+                kobject_put(&call->caller_phone->kobject);
         slab_free(call_cache, call);
 }
@@ -114 +116 @@
 call_t *ipc_call_alloc(void)
 {
-        // TODO: Allocate call and kobject in single allocation
-
         call_t *call = slab_alloc(call_cache, FRAME_ATOMIC);
         if (!call)
                 return NULL;
 
-        kobject_t *kobj = kobject_alloc(0);
-        if (!kobj) {
-                slab_free(call_cache, call);
-                return NULL;
-        }
-
         _ipc_call_init(call);
-        kobject_initialize(kobj, KOBJECT_TYPE_CALL, call);
-        call->kobject = kobj;
 
         return call;
@@ -181 +173 @@
         if (!connected) {
                 /* We still have phone->kobject's reference; drop it */
-                kobject_put(phone->kobject);
+                kobject_put(&phone->kobject);
         }
 
@@ -201 +193 @@
         atomic_store(&phone->active_calls, 0);
         phone->label = 0;
-        phone->kobject = NULL;
+        kobject_initialize(&phone->kobject, KOBJECT_TYPE_PHONE);
 }
 
@@ -294 +286 @@
                 /* This is a forgotten call and call->sender is not valid. */
                 spinlock_unlock(&call->forget_lock);
-                kobject_put(call->kobject);
+                kobject_put(&call->kobject);
                 return;
         } else {
@@ -352 +344 @@
 
         call->caller_phone = phone;
-        kobject_add_ref(phone->kobject);
+        kobject_add_ref(&phone->kobject);
 
         if (preforget) {
@@ -362 +354 @@
                 else
                         atomic_inc(&caller->answerbox.active_calls);
-                kobject_add_ref(phone->kobject);
+                kobject_add_ref(&phone->kobject);
                 call->sender = caller;
                 call->active = true;
@@ -479 +471 @@
 
                 /* Drop the answerbox reference */
-                kobject_put(phone->kobject);
+                kobject_put(&phone->kobject);
 
                 call_t *call = phone->hangup_call;
@@ -581 +573 @@
                 atomic_dec(&request->caller_phone->active_calls);
                 atomic_dec(&box->active_calls);
-                kobject_put(request->caller_phone->kobject);
+                kobject_put(&request->caller_phone->kobject);
         } else if (!list_empty(&box->calls)) {
                 /* Count received call */
@@ -697 +689 @@
                         task_release(phone->caller);
 
-                        kobject_put(phone->kobject);
+                        kobject_put(&phone->kobject);
 
                         /* Must start again */
@@ -704 +696 @@
 
                 mutex_unlock(&phone->lock);
-                kobject_put(phone->kobject);
+                kobject_put(&phone->kobject);
         }
 
@@ -728 +720 @@
          * must hold a reference to it.
          */
-        kobject_add_ref(call->kobject);
+        kobject_add_ref(&call->kobject);
 
         spinlock_unlock(&call->forget_lock);
@@ -735 +727 @@
         atomic_dec(&call->caller_phone->active_calls);
         atomic_dec(&TASK->answerbox.active_calls);
-        kobject_put(call->caller_phone->kobject);
+        kobject_put(&call->caller_phone->kobject);
 
         SYSIPC_OP(request_forget, call);
 
-        kobject_put(call->kobject);
+        kobject_put(&call->kobject);
 }
 
@@ -777 +769 @@
 static bool phone_cap_cleanup_cb(cap_t *cap, void *arg)
 {
-        ipc_phone_hangup(cap->kobject->phone);
+        ipc_phone_hangup(phone_from_kobject(cap->kobject));
         kobject_t *kobj = cap_unpublish(cap->task, cap->handle,
             KOBJECT_TYPE_PHONE);
@@ -798 +790 @@
                 SYSIPC_OP(answer_process, call);
 
-                kobject_put(call->kobject);
+                kobject_put(&call->kobject);
 
                 /*
@@ -892 +884 @@
         answerbox_cache = slab_cache_create("answerbox_t", sizeof(answerbox_t),
             0, NULL, NULL, 0);
+        irq_cache = slab_cache_create("irq_t", sizeof(irq_kobject_t),
+            0, NULL, NULL, 0);
 }
 
@@ -927 +921 @@
 static bool print_task_phone_cb(cap_t *cap, void *arg)
 {
-        phone_t *phone = cap->kobject->phone;
+        phone_t *phone = phone_from_kobject(cap->kobject);
 
         mutex_lock(&phone->lock);