Changeset 8e3498b in mainline for uspace/app/sysinst/futil.c

Timestamp:

2017-12-04T18:44:24Z (7 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

bde5c04

Parents:

40feeac

Message:

vfs_read/write() should return error code separately from number of bytes transferred.

File:

• uspace/app/sysinst/futil.c (modified) (6 diffs)

uspace/app/sysinst/futil.c

@@ -57 +57 @@
 {
         int sf, df;
-        ssize_t nr, nw;
+        size_t nr, nw;
         int rc;
         aoff64_t posr = 0, posw = 0;
@@ -72 +72 @@
 
         do {
-                nr = vfs_read(sf, &posr, buf, BUF_SIZE);
+                rc = vfs_read(sf, &posr, buf, BUF_SIZE, &nr);
+                if (rc != EOK)
+                        goto error;
                 if (nr == 0)
                         break;
-                if (nr < 0)
-                        return EIO;
-
-                nw = vfs_write(df, &posw, buf, nr);
-                if (nw <= 0)
-                        return EIO;
-        } while (true);
+
+                rc= vfs_write(df, &posw, buf, nr, &nw);
+                if (rc != EOK)
+                        goto error;
+
+        } while (nr == BUF_SIZE);
 
         (void) vfs_put(sf);
@@ -90 +91 @@
 
         return EOK;
+error:
+        vfs_put(sf);
+        vfs_put(df);
+        return rc;
 }
 
@@ -156 +161 @@
 {
         int sf;
-        ssize_t nr;
+        size_t nr;
+        int rc;
         size_t fsize;
         char *data;
@@ -168 +174 @@
                 vfs_put(sf);
                 return EIO;
-        }       
+        }
 
         fsize = st.size;
@@ -178 +184 @@
         }
 
-        nr = vfs_read(sf, (aoff64_t []) { 0 }, data, fsize);
-        if (nr != (ssize_t)fsize) {
+        rc = vfs_read(sf, (aoff64_t []) { 0 }, data, fsize, &nr);
+        if (rc != EOK || nr != fsize) {
                 vfs_put(sf);
                 free(data);