Changeset 90dd8aee in mainline for kernel/generic/src/printf/vprintf.c

Timestamp:

2025-04-10T17:55:36Z (4 days ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

8165a7a, c0d814a

Parents:

c55ab66

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2025-04-10 11:33:46)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2025-04-10 17:55:36)

Message:

Introduce a console lock to prevent line splitting in kernel output

It is a common occurrence to see broken lines on screen or in serial
output due to bad timing. This is an attempt to prevent that without
breaking anything.

It could be considered a stopgap solution, since the whole console
stack deserves a better/faster implementation.

File:

• kernel/generic/src/printf/vprintf.c (modified) (4 diffs)

kernel/generic/src/printf/vprintf.c

@@ -33 +33 @@
  */
 
+#include <arch/asm.h>
+#include <console/console.h>
 #include <print.h>
 #include <printf/printf_core.h>
 #include <putchar.h>
+#include <str.h>
 #include <synch/spinlock.h>
-#include <arch/asm.h>
 #include <typedefs.h>
-#include <str.h>
 
 static int vprintf_str_write(const char *str, size_t size, void *data)
@@ -74 +75 @@
         char32_t uc;
 
+        console_lock();
+
         while ((uc = str_decode(str, &offset, STR_NO_LIMIT)) != 0) {
                 putuchar(uc);
@@ -80 +83 @@
 
         putuchar('\n');
+
+        console_unlock();
         return chars;
 }
@@ -91 +96 @@
         };
 
-        return printf_core(fmt, &ps, ap);
+        console_lock();
+        int ret = printf_core(fmt, &ps, ap);
+        console_unlock();
+        return ret;
 }