Changeset 94795812 in mainline for kernel/generic/include/macros.h

Timestamp:

2012-11-05T21:52:35Z (12 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2d53cfc, 33c2952, efdfebc

Parents:

0941e9ae

Message:

Check for dangerous unsigned integer overflows in check_area_conflicts().

• Rename overflows_add() to overflows_into_positive().
• Introduce overflows() for simple sum overflow tests.

File:

• kernel/generic/include/macros.h (modified) (1 diff)

kernel/generic/include/macros.h

@@ -130 +130 @@
             | ((((uint64_t) (up)) & UINT32_C(0xffffffff)) << 32))
 
-/* Test for result wrap-around into positive numbers. */
-#define overflows_add(a, b) \
-        (((a) + (b) < (a)) && ((a) + (b)))
+/* Test for sum overflow. */
+#define overflows(a, b) \
+        ((a) + (b) < (a))
+
+/* Test for sum overflow into positive numbers. */
+#define overflows_into_positive(a, b)   \
+        (overflows((a), (b)) && ((a) + (b) > 0))
 
 /** Pseudorandom generator