Changeset a35b458 in mainline for uspace/lib/c/generic/dirent.c


Ignore:
Timestamp:
2018-03-02T20:10:49Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
f1380b7
Parents:
3061bc1
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-02-28 17:38:31)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-02 20:10:49)
Message:

style: Remove trailing whitespace on _all_ lines, including empty ones, for particular file types.

Command used: tools/srepl '\s\+$' '' -- *.c *.h *.py *.sh *.s *.S *.ag

Currently, whitespace on empty lines is very inconsistent.
There are two basic choices: Either remove the whitespace, or keep empty lines
indented to the level of surrounding code. The former is AFAICT more common,
and also much easier to do automatically.

Alternatively, we could write script for automatic indentation, and use that
instead. However, if such a script exists, it's possible to use the indented
style locally, by having the editor apply relevant conversions on load/save,
without affecting remote repository. IMO, it makes more sense to adopt
the simpler rule.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/lib/c/generic/dirent.c

    r3061bc1 ra35b458  
    5353                return NULL;
    5454        }
    55        
     55
    5656        int fd;
    5757        errno_t rc = vfs_lookup(dirname, WALK_DIRECTORY, &fd);
     
    6161                return NULL;
    6262        }
    63        
     63
    6464        rc = vfs_open(fd, MODE_READ);
    6565        if (rc != EOK) {
     
    6969                return NULL;
    7070        }
    71        
     71
    7272        dirp->fd = fd;
    7373        dirp->pos = 0;
     
    8585        errno_t rc;
    8686        ssize_t len = 0;
    87        
     87
    8888        rc = vfs_read_short(dirp->fd, dirp->pos, &dirp->res.d_name[0],
    8989            NAME_MAX + 1, &len);
     
    9292                return NULL;
    9393        }
    94        
     94
    9595        dirp->pos += len;
    96        
     96
    9797        return &dirp->res;
    9898}
Note: See TracChangeset for help on using the changeset viewer.