Changeset aa9ccf7 in mainline for uspace/drv/ohci/hc.c

Timestamp:

2011-04-11T13:15:25Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9f104af4

Parents:

fd153d3

Message:

More debug output and some fixes

Add mutex for scheduling and removing of batches
batch_data initialize the first TD not the second
disable and enable both isochronous and interrupt processing when scheduling periodic transfer.
undef the right macro in transfer_list initialization

File:

• uspace/drv/ohci/hc.c (modified) (8 diffs)

uspace/drv/ohci/hc.c

@@ -113 +113 @@
             ret, str_error(ret));
         hc_init_hw(instance);
+        fibril_mutex_initialize(&instance->guard);
 
         rh_init(&instance->rh, dev, instance->registers);
@@ -135 +136 @@
         }
 
+        fibril_mutex_lock(&instance->guard);
         switch (batch->transfer_type) {
         case USB_TRANSFER_CONTROL:
@@ -157 +159 @@
         case USB_TRANSFER_INTERRUPT:
         case USB_TRANSFER_ISOCHRONOUS:
-                instance->registers->control &= ~C_PLE;
+                instance->registers->control &= (~C_PLE & ~C_IE);
                 transfer_list_add_batch(
                     instance->transfers[batch->transfer_type], batch);
-                instance->registers->control |= C_PLE;
+                instance->registers->control |= C_PLE | C_IE;
+                usb_log_debug2("Added periodic transfer: %x.\n",
+                    instance->registers->periodic_current);
                 break;
         default:
                 break;
         }
+        fibril_mutex_unlock(&instance->guard);
         return EOK;
 }
@@ -178 +183 @@
         usb_log_debug("OHCI interrupt: %x.\n", status);
 
-
         if (status & IS_WDH) {
+                fibril_mutex_lock(&instance->guard);
+                usb_log_debug2("HCCA: %p-%p(%p).\n", instance->hcca,
+                    instance->registers->hcca, addr_to_phys(instance->hcca));
+                usb_log_debug2("Periodic current: %p.\n",
+                    instance->registers->periodic_current);
                 LIST_INITIALIZE(done);
                 transfer_list_remove_finished(
@@ -197 +206 @@
                         usb_transfer_batch_finish(batch);
                 }
+                fibril_mutex_unlock(&instance->guard);
         }
 }
@@ -208 +218 @@
                 instance->registers->interrupt_status = status;
                 hc_interrupt(instance, status);
-                async_usleep(10000);
+                async_usleep(50000);
         }
         return EOK;
@@ -345 +355 @@
         SETUP_TRANSFER_LIST(transfers_control, "CONTROL");
         SETUP_TRANSFER_LIST(transfers_bulk, "BULK");
-
+#undef SETUP_TRANSFER_LIST
         transfer_list_set_next(&instance->transfers_interrupt,
             &instance->transfers_isochronous);
@@ -360 +370 @@
 
         return EOK;
-#undef CHECK_RET_CLEAR_RETURN
 }
 /*----------------------------------------------------------------------------*/