Changeset b7fd2a0 in mainline for kernel/generic/src/ipc/ops/sharein.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/ipc/ops/sharein.c (modified) (2 diffs)

kernel/generic/src/ipc/ops/sharein.c

@@ -41 +41 @@
 #include <arch.h>
 
-static int answer_preprocess(call_t *answer, ipc_data_t *olddata)
+static errno_t answer_preprocess(call_t *answer, ipc_data_t *olddata)
 {
         if (!IPC_GET_RETVAL(answer->data)) {
@@ -49 +49 @@
                         
                 uintptr_t dst_base = (uintptr_t) -1;
-                int rc = as_area_share(AS, IPC_GET_ARG1(answer->data),
+                errno_t rc = as_area_share(AS, IPC_GET_ARG1(answer->data),
                     IPC_GET_ARG1(*olddata), as, IPC_GET_ARG2(answer->data),
                     &dst_base, IPC_GET_ARG3(answer->data));