Changeset b7fd2a0 in mainline for kernel/generic/src/proc/program.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/proc/program.c (modified) (5 diffs)

kernel/generic/src/proc/program.c

@@ -69 +69 @@
  *
  */
-int program_create(as_t *as, uintptr_t entry_addr, char *name, program_t *prg)
+errno_t program_create(as_t *as, uintptr_t entry_addr, char *name, program_t *prg)
 {
         prg->loader_status = EE_OK;
@@ -137 +137 @@
  *
  */
-int program_create_from_image(void *image_addr, char *name, program_t *prg)
+errno_t program_create_from_image(void *image_addr, char *name, program_t *prg)
 {
         as_t *as = as_create(0);
@@ -174 +174 @@
  *
  */
-int program_create_loader(program_t *prg, char *name)
+errno_t program_create_loader(program_t *prg, char *name)
 {
         as_t *as = as_create(0);
@@ -225 +225 @@
  *
  */
-sysarg_t sys_program_spawn_loader(char *uspace_name, size_t name_len)
+sys_errno_t sys_program_spawn_loader(char *uspace_name, size_t name_len)
 {
         /* Cap length of name and copy it from userspace. */
@@ -232 +232 @@
         
         char namebuf[TASK_NAME_BUFLEN];
-        int rc = copy_from_uspace(namebuf, uspace_name, name_len);
+        errno_t rc = copy_from_uspace(namebuf, uspace_name, name_len);
         if (rc != 0)
-                return (sysarg_t) rc;
+                return (sys_errno_t) rc;
         
         namebuf[name_len] = 0;