Changeset b7fd2a0 in mainline for kernel/generic/src/security/perm.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/security/perm.c (modified) (6 diffs)

kernel/generic/src/security/perm.c

@@ -84 +84 @@
  *
  */
-static int perm_grant(task_id_t taskid, perm_t perms)
+static errno_t perm_grant(task_id_t taskid, perm_t perms)
 {
         if (!(perm_get(TASK) & PERM_PERM))
@@ -116 +116 @@
  *
  */
-static int perm_revoke(task_id_t taskid, perm_t perms)
+static errno_t perm_revoke(task_id_t taskid, perm_t perms)
 {
         irq_spinlock_lock(&tasks_lock, true);
@@ -158 +158 @@
  *
  */
-sysarg_t sys_perm_grant(sysarg64_t *uspace_taskid, perm_t perms)
+sys_errno_t sys_perm_grant(sysarg64_t *uspace_taskid, perm_t perms)
 {
         sysarg64_t taskid;
-        int rc = copy_from_uspace(&taskid, uspace_taskid, sizeof(sysarg64_t));
+        errno_t rc = copy_from_uspace(&taskid, uspace_taskid, sizeof(sysarg64_t));
         if (rc != 0)
-                return (sysarg_t) rc;
+                return (sys_errno_t) rc;
         
         return perm_grant((task_id_t) taskid, perms);
@@ -179 +179 @@
  *
  */
-sysarg_t sys_perm_revoke(sysarg64_t *uspace_taskid, perm_t perms)
+sys_errno_t sys_perm_revoke(sysarg64_t *uspace_taskid, perm_t perms)
 {
         sysarg64_t taskid;
-        int rc = copy_from_uspace(&taskid, uspace_taskid, sizeof(sysarg64_t));
+        errno_t rc = copy_from_uspace(&taskid, uspace_taskid, sizeof(sysarg64_t));
         if (rc != 0)
-                return (sysarg_t) rc;
+                return (sys_errno_t) rc;
         
         return perm_revoke((task_id_t) taskid, perms);
@@ -203 +203 @@
  *
  */
-sysarg_t sys_perm_grant(sysarg_t taskid, perm_t perms)
+sys_errno_t sys_perm_grant(sysarg_t taskid, perm_t perms)
 {
         return perm_grant((task_id_t) taskid, perms);
@@ -219 +219 @@
  *
  */
-sysarg_t sys_perm_revoke(sysarg_t taskid, perm_t perms)
+sys_errno_t sys_perm_revoke(sysarg_t taskid, perm_t perms)
 {
         return perm_revoke((task_id_t) taskid, perms);