Changeset b7fd2a0 in mainline for kernel/generic/src/syscall/copy.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• kernel/generic/src/syscall/copy.c (modified) (2 diffs)

kernel/generic/src/syscall/copy.c

@@ -59 +59 @@
  * @return EOK on success or an error code from @ref errno.h.
  */
-int copy_from_uspace(void *dst, const void *uspace_src, size_t size)
+errno_t copy_from_uspace(void *dst, const void *uspace_src, size_t size)
 {
         ipl_t ipl;
-        int rc;
+        errno_t rc;
         
         assert(THREAD);
@@ -110 +110 @@
  * @return 0 on success or an error code from @ref errno.h.
  */
-int copy_to_uspace(void *uspace_dst, const void *src, size_t size)
+errno_t copy_to_uspace(void *uspace_dst, const void *src, size_t size)
 {
         ipl_t ipl;
-        int rc;
+        errno_t rc;
         
         assert(THREAD);