Changeset b7fd2a0 in mainline for uspace/app/mixerctl/mixerctl.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/mixerctl/mixerctl.c (modified) (5 diffs)

uspace/app/mixerctl/mixerctl.c

@@ -51 +51 @@
         const char* name = NULL;
         unsigned count = 0;
-        int ret = audio_mixer_get_info(exch, &name, &count);
+        errno_t ret = audio_mixer_get_info(exch, &name, &count);
         if (ret != EOK) {
                 printf("Failed to get mixer info: %s.\n", str_error(ret));
@@ -61 +61 @@
                 const char *name = NULL;
                 unsigned levels = 0, current = 0;
-                int ret =
+                errno_t ret =
                     audio_mixer_get_item_info(exch, i, &name, &levels);
                 if (ret != EOK) {
@@ -99 +99 @@
         const unsigned item = get_number(argv[params++]);
         const unsigned value = get_number(argv[params]);
-        int ret = audio_mixer_set_item_level(exch, item, value);
+        errno_t ret = audio_mixer_set_item_level(exch, item, value);
         if (ret != EOK) {
                 printf("Failed to set item level: %s.\n", str_error(ret));
@@ -118 +118 @@
         unsigned value = 0;
 
-        int ret = audio_mixer_get_item_level(exch, item, &value);
+        errno_t ret = audio_mixer_get_item_level(exch, item, &value);
         if (ret != EOK) {
                 printf("Failed to get item level: %s.\n", str_error(ret));
@@ -148 +148 @@
 
         service_id_t mixer_sid;
-        int rc = loc_service_get_id(service, &mixer_sid, 0);
+        errno_t rc = loc_service_get_id(service, &mixer_sid, 0);
         if (rc != EOK) {
                 printf("Failed to resolve service '%s': %s.\n",