Changeset b7fd2a0 in mainline for uspace/app/mkbd/main.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/mkbd/main.c (modified) (5 diffs)

uspace/app/mkbd/main.c

@@ -60 +60 @@
 static async_sess_t *dev_sess = NULL;
 
-static int initialize_report_parser(async_sess_t *dev_sess,
+static errno_t initialize_report_parser(async_sess_t *dev_sess,
     usb_hid_report_t **report)
 {
@@ -67 +67 @@
                 return ENOMEM;
         
-        int rc = usb_hid_report_init(*report);
+        errno_t rc = usb_hid_report_init(*report);
         if (rc != EOK) {
                 usb_hid_report_deinit(*report);
@@ -131 +131 @@
         
         uint8_t report_id;
-        int rc = usb_hid_parse_report(report, buffer, size, &report_id);
+        errno_t rc = usb_hid_parse_report(report, buffer, size, &report_id);
         if (rc != EOK)
                 return;
@@ -165 +165 @@
 }
 
-static int wait_for_quit_fibril(void *arg)
+static errno_t wait_for_quit_fibril(void *arg)
 {
         console_ctrl_t *con = console_init(stdin, stdout);
@@ -218 +218 @@
         devman_handle_t dev_handle = 0;
         
-        int rc = usb_resolve_device_handle(devpath, &dev_handle);
+        errno_t rc = usb_resolve_device_handle(devpath, &dev_handle);
         if (rc != EOK) {
                 printf("Device not found or not of USB kind: %s.\n",