Changeset b7fd2a0 in mainline for uspace/app/nterm/conn.c


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/app/nterm/conn.c

    r36f0738 rb7fd2a0  
    6969static void conn_data_avail(tcp_conn_t *conn)
    7070{
    71         int rc;
     71        errno_t rc;
    7272        size_t nrecv;
    7373
     
    8686}
    8787
    88 int conn_open(const char *hostport)
     88errno_t conn_open(const char *hostport)
    8989{
    9090        inet_ep2_t epp;
    9191        const char *errmsg;
    92         int rc;
     92        errno_t rc;
    9393
    9494        inet_ep2_init(&epp);
     
    126126}
    127127
    128 int conn_send(void *data, size_t size)
     128errno_t conn_send(void *data, size_t size)
    129129{
    130         int rc = tcp_conn_send(conn, data, size);
     130        errno_t rc = tcp_conn_send(conn, data, size);
    131131        if (rc != EOK)
    132132                return EIO;
Note: See TracChangeset for help on using the changeset viewer.