Changeset b7fd2a0 in mainline for uspace/app/rcubench/rcubench.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/rcubench/rcubench.c (modified) (2 diffs)

uspace/app/rcubench/rcubench.c

@@ -126 +126 @@
                 thread_id_t tid;
                 /* Also sets up a fibril for the thread. */
-                int ret = thread_create(thread_func, bench, "rcubench-t", &tid);
+                errno_t ret = thread_create(thread_func, bench, "rcubench-t", &tid);
                 if (ret != EOK) {
                         printf("Error: Failed to create benchmark thread.\n");
@@ -217 +217 @@
         /* Determine iteration count. */
         uint32_t iter_cnt = 0;
-        int ret = str_uint32_t(argv[2], NULL, 0, true, &iter_cnt);
+        errno_t ret = str_uint32_t(argv[2], NULL, 0, true, &iter_cnt);
 
         if (ret == EOK && 1 <= iter_cnt) {