Changeset b7fd2a0 in mainline for uspace/app/taskdump/fibrildump.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/taskdump/fibrildump.c (modified) (6 diffs)

uspace/app/taskdump/fibrildump.c

@@ -43 +43 @@
 #include <udebug.h>
 
-static int fibrildump_read_uintptr(void *, uintptr_t, uintptr_t *);
+static errno_t fibrildump_read_uintptr(void *, uintptr_t, uintptr_t *);
 
 static stacktrace_ops_t fibrildump_st_ops = {
@@ -49 +49 @@
 }; 
 
-static int fibrildump_read_uintptr(void *arg, uintptr_t addr, uintptr_t *data)
+static errno_t fibrildump_read_uintptr(void *arg, uintptr_t addr, uintptr_t *data)
 {
         async_sess_t *sess = (async_sess_t *)arg;
@@ -56 +56 @@
 }
 
-static int read_link(async_sess_t *sess, uintptr_t addr, link_t *link)
+static errno_t read_link(async_sess_t *sess, uintptr_t addr, link_t *link)
 {
-        int rc;
+        errno_t rc;
 
         rc = udebug_mem_read(sess, (void *)link, addr, sizeof(link_t));
@@ -64 +64 @@
 }
 
-static int read_fibril(async_sess_t *sess, uintptr_t addr, fibril_t *fibril)
+static errno_t read_fibril(async_sess_t *sess, uintptr_t addr, fibril_t *fibril)
 {
-        int rc;
+        errno_t rc;
 
         rc = udebug_mem_read(sess, (void *)fibril, addr, sizeof(fibril_t));
@@ -72 +72 @@
 }
 
-int fibrils_dump(symtab_t *symtab, async_sess_t *sess)
+errno_t fibrils_dump(symtab_t *symtab, async_sess_t *sess)
 {
         uintptr_t fibril_list_addr;
@@ -79 +79 @@
         uintptr_t addr, fibril_addr;
         uintptr_t pc, fp;
-        int rc;
+        errno_t rc;
 
         /*