Changeset b7fd2a0 in mainline for uspace/app/tester/mm/mapping1.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/tester/mm/mapping1.c (modified) (3 diffs)

uspace/app/tester/mm/mapping1.c

@@ -66 +66 @@
     verify_mapping((area), (page_count), (expected_rc), #expected_rc)
 
-static bool verify_mapping(void *area, int page_count, int expected_rc,
+static bool verify_mapping(void *area, int page_count, errno_t expected_rc,
     const char *expected_rc_str)
 {
@@ -73 +73 @@
         for (i = 0; i < page_count; i++) {
                 void *page_start = ((char *) area) + PAGE_SIZE * i;
-                int rc = as_get_physical_mapping(page_start, NULL);
+                errno_t rc = as_get_physical_mapping(page_start, NULL);
                 if (rc != expected_rc) {
                         TPRINTF("as_get_physical_mapping() = %s != %s\n",
@@ -85 +85 @@
 const char *test_mapping1(void)
 {
-        int rc;
+        errno_t rc;
         
         size_t buffer1_len = BUFFER1_PAGES * PAGE_SIZE;