Changeset b7fd2a0 in mainline for uspace/app/untar/main.c


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • uspace/app/untar/main.c

    r36f0738 rb7fd2a0  
    4444}
    4545
    46 static int skip_blocks(FILE *tarfile, size_t valid_data_size)
     46static errno_t skip_blocks(FILE *tarfile, size_t valid_data_size)
    4747{
    4848        size_t blocks_to_read = get_block_count(valid_data_size);
    … …  
    5858}
    5959
    60 static int handle_normal_file(const tar_header_t *header, FILE *tarfile)
     60static errno_t handle_normal_file(const tar_header_t *header, FILE *tarfile)
    6161{
    6262        // FIXME: create the directory first
    … …  
    6969        }
    7070
    71         int rc = EOK;
     71        errno_t rc = EOK;
    7272        size_t bytes_remaining = header->size;
    7373        size_t blocks = get_block_count(bytes_remaining);
    … …  
    101101}
    102102
    103 static int handle_directory(const tar_header_t *header, FILE *tarfile)
     103static errno_t handle_directory(const tar_header_t *header, FILE *tarfile)
    104104{
    105         int rc;
     105        errno_t rc;
    106106
    107107        rc = vfs_link_path(header->filename, KIND_DIRECTORY, NULL);
    … …  
    140140                        break;
    141141                }
    142                 int rc = tar_header_parse(&header, &header_raw);
     142                errno_t rc = tar_header_parse(&header, &header_raw);
    143143                if (rc == EEMPTY) {
    144144                        continue;
Note: See TracChangeset for help on using the changeset viewer.