Changeset b7fd2a0 in mainline for uspace/app/usbinfo/list.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/usbinfo/list.c (modified) (3 diffs)

uspace/app/usbinfo/list.c

@@ -53 +53 @@
 {
         char path[MAX_PATH_LENGTH];
-        int rc = devman_fun_get_path(handle, path, MAX_PATH_LENGTH);
+        errno_t rc = devman_fun_get_path(handle, path, MAX_PATH_LENGTH);
         if (rc != EOK) {
                 printf(NAME "Failed to get path for device %"PRIun"\n", handle);
@@ -64 +64 @@
 {
         devman_handle_t hc_handle = 0;
-        int rc = devman_fun_sid_to_handle(svc, &hc_handle);
+        errno_t rc = devman_fun_sid_to_handle(svc, &hc_handle);
         if (rc != EOK) {
                 printf(NAME ": Error resolving handle of HC with SID %"
@@ -133 +133 @@
         service_id_t *svcs;
         size_t count;
-        int rc;
+        errno_t rc;
 
         rc = loc_category_get_id(USB_HC_CATEGORY, &usbhc_cat, 0);