Changeset b7fd2a0 in mainline for uspace/app/vuhid/main.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/vuhid/main.c (modified) (2 diffs)

uspace/app/vuhid/main.c

@@ -216 +216 @@
         /* Determine which interfaces to initialize. */
         for (int i = optind; i < argc; i++) {
-                int rc = add_interface_by_id(available_hid_interfaces, argv[i],
+                errno_t rc = add_interface_by_id(available_hid_interfaces, argv[i],
                     &hid_dev);
                 if (rc != EOK) {
@@ -234 +234 @@
         }
 
-        const int rc = usbvirt_device_plug(&hid_dev, controller);
+        const errno_t rc = usbvirt_device_plug(&hid_dev, controller);
         if (rc != EOK) {
                 printf("Unable to start communication with VHCD `%s': %s.\n",