Changeset b7fd2a0 in mainline for uspace/app/vuhid/stdreq.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/app/vuhid/stdreq.c (modified) (4 diffs)

uspace/app/vuhid/stdreq.c

@@ -43 +43 @@
         vuhid_data_t *vuhid = device->device_data
 
-int req_get_descriptor(usbvirt_device_t *device,
+errno_t req_get_descriptor(usbvirt_device_t *device,
     const usb_device_request_setup_packet_t *setup_packet,
     uint8_t *data, size_t *act_size)
@@ -70 +70 @@
 }
 
-int req_set_protocol(usbvirt_device_t *device,
+errno_t req_set_protocol(usbvirt_device_t *device,
     const usb_device_request_setup_packet_t *setup_packet,
     uint8_t *data, size_t *act_size)
@@ -89 +89 @@
 }
 
-int req_set_report(usbvirt_device_t *device,
+errno_t req_set_report(usbvirt_device_t *device,
     const usb_device_request_setup_packet_t *setup_packet,
     uint8_t *data, size_t *act_size)
@@ -109 +109 @@
 
         /* SET_REPORT is translated to data out */
-        int rc = iface->on_data_out(iface, data, data_length);
+        errno_t rc = iface->on_data_out(iface, data, data_length);
 
         return rc;