Changeset b7fd2a0 in mainline for uspace/drv/audio/hdaudio/hdaudio.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/audio/hdaudio/hdaudio.c (modified) (7 diffs)

uspace/drv/audio/hdaudio/hdaudio.c

@@ -52 +52 @@
 #define NAME "hdaudio"
 
-static int hda_dev_add(ddf_dev_t *dev);
-static int hda_dev_remove(ddf_dev_t *dev);
-static int hda_dev_gone(ddf_dev_t *dev);
-static int hda_fun_online(ddf_fun_t *fun);
-static int hda_fun_offline(ddf_fun_t *fun);
+static errno_t hda_dev_add(ddf_dev_t *dev);
+static errno_t hda_dev_remove(ddf_dev_t *dev);
+static errno_t hda_dev_gone(ddf_dev_t *dev);
+static errno_t hda_fun_online(ddf_fun_t *fun);
+static errno_t hda_fun_offline(ddf_fun_t *fun);
 
 static void hdaudio_interrupt(ipc_call_t *, ddf_dev_t *);
@@ -148 +148 @@
 };
 
-static int hda_dev_add(ddf_dev_t *dev)
+static errno_t hda_dev_add(ddf_dev_t *dev)
 {
         ddf_fun_t *fun_pcm = NULL;
@@ -160 +160 @@
         int i;
         void *regs = NULL;
-        int rc;
+        errno_t rc;
 
         ddf_msg(LVL_NOTE, "hda_dev_add()");
@@ -318 +318 @@
 }
 
-static int hda_dev_remove(ddf_dev_t *dev)
+static errno_t hda_dev_remove(ddf_dev_t *dev)
 {
         hda_t *hda = (hda_t *)ddf_dev_data_get(dev);
-        int rc;
+        errno_t rc;
 
         ddf_msg(LVL_DEBUG, "hda_dev_remove(%p)", dev);
@@ -340 +340 @@
 }
 
-static int hda_dev_gone(ddf_dev_t *dev)
+static errno_t hda_dev_gone(ddf_dev_t *dev)
 {
         hda_t *hda = (hda_t *)ddf_dev_data_get(dev);
-        int rc;
+        errno_t rc;
 
         ddf_msg(LVL_DEBUG, "hda_dev_remove(%p)", dev);
@@ -356 +356 @@
 }
 
-static int hda_fun_online(ddf_fun_t *fun)
+static errno_t hda_fun_online(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "hda_fun_online()");
@@ -362 +362 @@
 }
 
-static int hda_fun_offline(ddf_fun_t *fun)
+static errno_t hda_fun_offline(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "hda_fun_offline()");