Changeset b7fd2a0 in mainline for uspace/drv/audio/sb16/mixer.h


Ignore:
Timestamp:
2018-01-13T03:10:29Z (7 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
a53ed3a
Parents:
36f0738
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/drv/audio/sb16/mixer.h

    r36f0738 rb7fd2a0  
    5151
    5252const char * sb_mixer_type_str(sb_mixer_type_t type);
    53 int sb_mixer_init(sb_mixer_t *mixer, sb16_regs_t *regs, sb_mixer_type_t type);
     53errno_t sb_mixer_init(sb_mixer_t *mixer, sb16_regs_t *regs, sb_mixer_type_t type);
    5454int sb_mixer_get_control_item_count(const sb_mixer_t *mixer);
    55 int sb_mixer_get_control_item_info(const sb_mixer_t *mixer, unsigned index,
     55errno_t sb_mixer_get_control_item_info(const sb_mixer_t *mixer, unsigned index,
    5656    const char **name, unsigned *levels);
    57 int sb_mixer_get_control_item_value(const sb_mixer_t *mixer, unsigned index,
     57errno_t sb_mixer_get_control_item_value(const sb_mixer_t *mixer, unsigned index,
    5858    unsigned *value);
    59 int sb_mixer_set_control_item_value(const sb_mixer_t *mixer, unsigned index,
     59errno_t sb_mixer_set_control_item_value(const sb_mixer_t *mixer, unsigned index,
    6060    unsigned value);
    6161#endif
Note: See TracChangeset for help on using the changeset viewer.