Changeset b7fd2a0 in mainline for uspace/drv/block/ata_bd/main.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/block/ata_bd/main.c (modified) (10 diffs)

uspace/drv/block/ata_bd/main.c

@@ -41 +41 @@
 #include "main.h"
 
-static int ata_dev_add(ddf_dev_t *dev);
-static int ata_dev_remove(ddf_dev_t *dev);
-static int ata_dev_gone(ddf_dev_t *dev);
-static int ata_fun_online(ddf_fun_t *fun);
-static int ata_fun_offline(ddf_fun_t *fun);
+static errno_t ata_dev_add(ddf_dev_t *dev);
+static errno_t ata_dev_remove(ddf_dev_t *dev);
+static errno_t ata_dev_gone(ddf_dev_t *dev);
+static errno_t ata_fun_online(ddf_fun_t *fun);
+static errno_t ata_fun_offline(ddf_fun_t *fun);
 
 static void ata_bd_connection(ipc_callid_t, ipc_call_t *, void *);
@@ -62 +62 @@
 };
 
-static int ata_get_res(ddf_dev_t *dev, ata_base_t *ata_res)
+static errno_t ata_get_res(ddf_dev_t *dev, ata_base_t *ata_res)
 {
         async_sess_t *parent_sess;
         hw_res_list_parsed_t hw_res;
-        int rc;
+        errno_t rc;
 
         parent_sess = ddf_dev_parent_sess_get(dev);
@@ -108 +108 @@
  * @return     EOK on success or an error code.
  */
-static int ata_dev_add(ddf_dev_t *dev)
+static errno_t ata_dev_add(ddf_dev_t *dev)
 {
         ata_ctrl_t *ctrl;
         ata_base_t res;
-        int rc;
+        errno_t rc;
 
         rc = ata_get_res(dev, &res);
@@ -151 +151 @@
 }
 
-int ata_fun_create(disk_t *disk)
+errno_t ata_fun_create(disk_t *disk)
 {
         ata_ctrl_t *ctrl = disk->ctrl;
-        int rc;
+        errno_t rc;
         char *fun_name = NULL;
         ddf_fun_t *fun = NULL;
@@ -212 +212 @@
 }
 
-int ata_fun_remove(disk_t *disk)
-{
-        int rc;
+errno_t ata_fun_remove(disk_t *disk)
+{
+        errno_t rc;
         char *fun_name;
 
@@ -250 +250 @@
 }
 
-int ata_fun_unbind(disk_t *disk)
-{
-        int rc;
+errno_t ata_fun_unbind(disk_t *disk)
+{
+        errno_t rc;
         char *fun_name;
 
@@ -282 +282 @@
 }
 
-static int ata_dev_remove(ddf_dev_t *dev)
+static errno_t ata_dev_remove(ddf_dev_t *dev)
 {
         ata_ctrl_t *ctrl = (ata_ctrl_t *)ddf_dev_data_get(dev);
@@ -291 +291 @@
 }
 
-static int ata_dev_gone(ddf_dev_t *dev)
+static errno_t ata_dev_gone(ddf_dev_t *dev)
 {
         ata_ctrl_t *ctrl = (ata_ctrl_t *)ddf_dev_data_get(dev);
@@ -300 +300 @@
 }
 
-static int ata_fun_online(ddf_fun_t *fun)
+static errno_t ata_fun_online(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "ata_fun_online()");
@@ -306 +306 @@
 }
 
-static int ata_fun_offline(ddf_fun_t *fun)
+static errno_t ata_fun_offline(ddf_fun_t *fun)
 {
         ddf_msg(LVL_DEBUG, "ata_fun_offline()");