Changeset b7fd2a0 in mainline for uspace/drv/bus/usb/uhci/main.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/bus/usb/uhci/main.c (modified) (5 diffs)

uspace/drv/bus/usb/uhci/main.c

@@ -49 +49 @@
 #define NAME "uhci"
 
-static int uhci_driver_init(hcd_t *, const hw_res_list_parsed_t *, bool);
+static errno_t uhci_driver_init(hcd_t *, const hw_res_list_parsed_t *, bool);
 static void uhci_driver_fini(hcd_t *);
-static int disable_legacy(ddf_dev_t *);
+static errno_t disable_legacy(ddf_dev_t *);
 
 static const ddf_hc_driver_t uhci_hc_driver = {
@@ -67 +67 @@
 };
 
-static int uhci_driver_init(hcd_t *hcd, const hw_res_list_parsed_t *res, bool irq)
+static errno_t uhci_driver_init(hcd_t *hcd, const hw_res_list_parsed_t *res, bool irq)
 {
         assert(hcd);
@@ -76 +76 @@
                 return ENOMEM;
 
-        const int ret = hc_init(instance, res, irq);
+        const errno_t ret = hc_init(instance, res, irq);
         if (ret == EOK) {
                 hcd_set_implementation(hcd, instance, &uhci_hc_driver.ops);
@@ -101 +101 @@
  * @return Error code.
  */
-static int disable_legacy(ddf_dev_t *device)
+static errno_t disable_legacy(ddf_dev_t *device)
 {
         assert(device);
@@ -119 +119 @@
  * @return Error code.
  */
-static int uhci_dev_add(ddf_dev_t *device)
+static errno_t uhci_dev_add(ddf_dev_t *device)
 {
         usb_log_debug2("uhci_dev_add() called\n");