Changeset b7fd2a0 in mainline for uspace/drv/bus/usb/vhc/hub/hub.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/bus/usb/vhc/hub/hub.c (modified) (3 diffs)

uspace/drv/bus/usb/vhc/hub/hub.c

@@ -63 +63 @@
 static void set_port_status_change(hub_port_t *, hub_status_change_t);
 static void clear_port_status_change(hub_port_t *, uint16_t);
-static int set_port_state_delayed_fibril(void *);
+static errno_t set_port_state_delayed_fibril(void *);
 static void set_port_state_delayed(hub_t *, size_t, suseconds_t,
     hub_port_state_t, hub_port_state_t);
@@ -163 +163 @@
  * @return Error code.
  */
-int hub_disconnect_device(hub_t *hub, void *device)
+errno_t hub_disconnect_device(hub_t *hub, void *device)
 {
         size_t index = hub_find_device(hub, device);
@@ -461 +461 @@
  * @return Always EOK.
  */
-static int set_port_state_delayed_fibril(void *arg)
+static errno_t set_port_state_delayed_fibril(void *arg)
 {
         struct delay_port_state_change *change