Changeset b7fd2a0 in mainline for uspace/drv/bus/usb/vhc/hub/virthubops.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/bus/usb/vhc/hub/virthubops.c (modified) (9 diffs)

uspace/drv/bus/usb/vhc/hub/virthubops.c

@@ -63 +63 @@
 
 /** Callback for data request. */
-static int req_on_status_change_pipe(usbvirt_device_t *dev,
+static errno_t req_on_status_change_pipe(usbvirt_device_t *dev,
     usb_endpoint_t endpoint, usb_transfer_type_t tr_type,
     void *buffer, size_t buffer_size, size_t *actual_size)
@@ -109 +109 @@
  * @return Error code.
  */
-static int req_clear_hub_feature(usbvirt_device_t *dev,
+static errno_t req_clear_hub_feature(usbvirt_device_t *dev,
     const usb_device_request_setup_packet_t *request, uint8_t *data,
     size_t *act_size)
@@ -123 +123 @@
  * @return Error code.
  */
-static int req_clear_port_feature(usbvirt_device_t *dev,
-    const usb_device_request_setup_packet_t *request, uint8_t *data,
-    size_t *act_size)
-{
-        int rc;
+static errno_t req_clear_port_feature(usbvirt_device_t *dev,
+    const usb_device_request_setup_packet_t *request, uint8_t *data,
+    size_t *act_size)
+{
+        errno_t rc;
         size_t port = request->index - 1;
         usb_hub_class_feature_t feature = request->value;
@@ -203 +203 @@
  * @return Error code.
  */
-static int req_get_bus_state(usbvirt_device_t *dev,
+static errno_t req_get_bus_state(usbvirt_device_t *dev,
     const usb_device_request_setup_packet_t *request, uint8_t *data,
     size_t *act_size)
@@ -217 +217 @@
  * @return Error code.
  */
-static int req_get_descriptor(usbvirt_device_t *dev,
+static errno_t req_get_descriptor(usbvirt_device_t *dev,
     const usb_device_request_setup_packet_t *request, uint8_t *data,
     size_t *act_size)
@@ -238 +238 @@
  * @return Error code.
  */
-static int req_get_hub_status(usbvirt_device_t *dev,
+static errno_t req_get_hub_status(usbvirt_device_t *dev,
     const usb_device_request_setup_packet_t *request, uint8_t *data,
     size_t *act_size)
@@ -257 +257 @@
  * @return Error code.
  */
-static int req_get_port_status(usbvirt_device_t *dev,
+static errno_t req_get_port_status(usbvirt_device_t *dev,
     const usb_device_request_setup_packet_t *request, uint8_t *data,
     size_t *act_size)
@@ -282 +282 @@
  * @return Error code.
  */
-static int req_set_hub_feature(usbvirt_device_t *dev,
+static errno_t req_set_hub_feature(usbvirt_device_t *dev,
     const usb_device_request_setup_packet_t *request, uint8_t *data,
     size_t *act_size)
@@ -296 +296 @@
  * @return Error code.
  */
-static int req_set_port_feature(usbvirt_device_t *dev,
-    const usb_device_request_setup_packet_t *request, uint8_t *data,
-    size_t *act_size)
-{
-        int rc = ENOTSUP;
+static errno_t req_set_port_feature(usbvirt_device_t *dev,
+    const usb_device_request_setup_packet_t *request, uint8_t *data,
+    size_t *act_size)
+{
+        errno_t rc = ENOTSUP;
         size_t port = request->index - 1;
         usb_hub_class_feature_t feature = request->value;