Changeset b7fd2a0 in mainline for uspace/drv/char/i8042/main.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/char/i8042/main.c (modified) (3 diffs)

uspace/drv/char/i8042/main.c

@@ -55 +55 @@
  *
  */
-static int get_my_registers(ddf_dev_t *dev, addr_range_t *p_io_reg,
+static errno_t get_my_registers(ddf_dev_t *dev, addr_range_t *p_io_reg,
     int *kbd_irq, int *mouse_irq)
 {
@@ -66 +66 @@
         hw_res_list_parsed_t hw_resources;
         hw_res_list_parsed_init(&hw_resources);
-        const int ret = hw_res_get_list_parsed(parent_sess, &hw_resources, 0);
+        const errno_t ret = hw_res_get_list_parsed(parent_sess, &hw_resources, 0);
         if (ret != EOK)
                 return ret;
@@ -96 +96 @@
  *
  */
-static int i8042_dev_add(ddf_dev_t *device)
+static errno_t i8042_dev_add(ddf_dev_t *device)
 {
         addr_range_t io_regs;
         int kbd = 0;
         int mouse = 0;
-        int rc;
+        errno_t rc;
         
         if (!device)