Changeset b7fd2a0 in mainline for uspace/drv/fb/kfb/port.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/fb/kfb/port.c (modified) (7 diffs)

uspace/drv/fb/kfb/port.c

@@ -86 +86 @@
 static vslmode_list_element_t pixel_mode;
 
-static int kfb_claim(visualizer_t *vs)
+static errno_t kfb_claim(visualizer_t *vs)
 {
         return physmem_map(kfb.paddr + kfb.offset,
@@ -93 +93 @@
 }
 
-static int kfb_yield(visualizer_t *vs)
-{
-        int rc;
+static errno_t kfb_yield(visualizer_t *vs)
+{
+        errno_t rc;
 
         if (vs->mode_set) {
@@ -109 +109 @@
 }
 
-static int kfb_handle_damage_pixels(visualizer_t *vs,
+static errno_t kfb_handle_damage_pixels(visualizer_t *vs,
     sysarg_t x0, sysarg_t y0, sysarg_t width, sysarg_t height,
     sysarg_t x_offset, sysarg_t y_offset)
@@ -137 +137 @@
 }
 
-static int kfb_change_mode(visualizer_t *vs, vslmode_t new_mode)
+static errno_t kfb_change_mode(visualizer_t *vs, vslmode_t new_mode)
 {
         vs->ops.handle_damage = kfb_handle_damage_pixels;
@@ -143 +143 @@
 }
 
-static int kfb_suspend(visualizer_t *vs)
-{
-        return EOK;
-}
-
-static int kfb_wakeup(visualizer_t *vs)
+static errno_t kfb_suspend(visualizer_t *vs)
+{
+        return EOK;
+}
+
+static errno_t kfb_wakeup(visualizer_t *vs)
 {
         return EOK;
@@ -165 +165 @@
 {
         visualizer_t *vsl;
-        int rc;
+        errno_t rc;
 
         vsl = (visualizer_t *) ddf_fun_data_get((ddf_fun_t *)arg);
@@ -177 +177 @@
 }
 
-int port_init(ddf_dev_t *dev)
+errno_t port_init(ddf_dev_t *dev)
 {
         sysarg_t present;
-        int rc = sysinfo_get_value("fb", &present);
+        errno_t rc = sysinfo_get_value("fb", &present);
         if (rc != EOK)
                 present = false;