Changeset b7fd2a0 in mainline for uspace/drv/hid/usbhid/multimedia/multimedia.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/hid/usbhid/multimedia/multimedia.c (modified) (3 diffs)

uspace/drv/hid/usbhid/multimedia/multimedia.c

@@ -153 +153 @@
 }
 
-int usb_multimedia_init(struct usb_hid_dev *hid_dev, void **data)
+errno_t usb_multimedia_init(struct usb_hid_dev *hid_dev, void **data)
 {
         if (hid_dev == NULL || hid_dev->usb_dev == NULL) {
@@ -182 +182 @@
         //todo Autorepeat?
 
-        int rc = ddf_fun_bind(fun);
+        errno_t rc = ddf_fun_bind(fun);
         if (rc != EOK) {
                 usb_log_error("Could not bind DDF function: %s.\n",
@@ -248 +248 @@
                 return true; /* This might be a temporary failure. */
 
-        int ret =
+        errno_t ret =
             usb_hid_report_path_append_item(path, USB_HIDUT_PAGE_CONSUMER, 0);
         if (ret != EOK) {