Changeset b7fd2a0 in mainline for uspace/drv/intctl/apic/apic.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/intctl/apic/apic.c (modified) (4 diffs)

uspace/drv/intctl/apic/apic.c

@@ -140 +140 @@
 }
 
-static int apic_enable_irq(apic_t *apic, sysarg_t irq)
+static errno_t apic_enable_irq(apic_t *apic, sysarg_t irq)
 {
         io_redirection_reg_t reg;
@@ -207 +207 @@
 
 /** Add APIC device. */
-int apic_add(apic_t *apic, apic_res_t *res)
+errno_t apic_add(apic_t *apic, apic_res_t *res)
 {
         sysarg_t have_apic;
         ddf_fun_t *fun_a = NULL;
         void *regs;
-        int rc;
+        errno_t rc;
         
         if ((sysinfo_get_value("apic", &have_apic) != EOK) || (!have_apic)) {
@@ -254 +254 @@
 
 /** Remove APIC device */
-int apic_remove(apic_t *apic)
+errno_t apic_remove(apic_t *apic)
 {
         return ENOTSUP;
@@ -260 +260 @@
 
 /** APIC device gone */
-int apic_gone(apic_t *apic)
+errno_t apic_gone(apic_t *apic)
 {
         return ENOTSUP;