Changeset b7fd2a0 in mainline for uspace/drv/intctl/i8259/i8259.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/intctl/i8259/i8259.c (modified) (5 diffs)

uspace/drv/intctl/i8259/i8259.c

@@ -64 +64 @@
 #define PIC_MAX_IRQ  15
 
-static int pic_enable_irq(i8259_t *i8259, sysarg_t irq)
+static errno_t pic_enable_irq(i8259_t *i8259, sysarg_t irq)
 {
         if (irq > PIC_MAX_IRQ)
@@ -136 +136 @@
 
 /** Add i8259 device. */
-int i8259_add(i8259_t *i8259, i8259_res_t *res)
+errno_t i8259_add(i8259_t *i8259, i8259_res_t *res)
 {
         sysarg_t have_i8259;
@@ -142 +142 @@
         ioport8_t *regs1;
         ddf_fun_t *fun_a = NULL;
-        int rc;
+        errno_t rc;
         
         if ((sysinfo_get_value("i8259", &have_i8259) != EOK) || (!have_i8259)) {
@@ -187 +187 @@
 
 /** Remove i8259 device */
-int i8259_remove(i8259_t *i8259)
+errno_t i8259_remove(i8259_t *i8259)
 {
         return ENOTSUP;
@@ -193 +193 @@
 
 /** i8259 device gone */
-int i8259_gone(i8259_t *i8259)
+errno_t i8259_gone(i8259_t *i8259)
 {
         return ENOTSUP;