Changeset b7fd2a0 in mainline for uspace/drv/nic/ar9271/htc.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/drv/nic/ar9271/htc.c (modified) (15 diffs)

uspace/drv/nic/ar9271/htc.c

@@ -66 +66 @@
 }
 
-int htc_init_new_vif(htc_device_t *htc_device)
+errno_t htc_init_new_vif(htc_device_t *htc_device)
 {
         htc_vif_msg_t vif_msg;
@@ -153 +153 @@
  *
  */
-int htc_send_control_message(htc_device_t *htc_device, void *buffer,
+errno_t htc_send_control_message(htc_device_t *htc_device, void *buffer,
     size_t buffer_size, uint8_t endpoint_id)
 {
@@ -176 +176 @@
  *
  */
-int htc_send_data_message(htc_device_t *htc_device, void *buffer,
+errno_t htc_send_data_message(htc_device_t *htc_device, void *buffer,
     size_t buffer_size, uint8_t endpoint_id)
 {
@@ -199 +199 @@
  *
  */
-int htc_read_data_message(htc_device_t *htc_device, void *buffer,
+errno_t htc_read_data_message(htc_device_t *htc_device, void *buffer,
     size_t buffer_size, size_t *transferred_size)
 {
@@ -219 +219 @@
  *
  */
-int htc_read_control_message(htc_device_t *htc_device, void *buffer,
+errno_t htc_read_control_message(htc_device_t *htc_device, void *buffer,
     size_t buffer_size, size_t *transferred_size)
 {
@@ -239 +239 @@
  *
  */
-static int htc_connect_service(htc_device_t *htc_device,
+static errno_t htc_connect_service(htc_device_t *htc_device,
     wmi_services_t service_id, int *response_endpoint_no)
 {
@@ -261 +261 @@
         
         /* Send HTC message. */
-        int rc = htc_send_control_message(htc_device, buffer, buffer_size,
+        errno_t rc = htc_send_control_message(htc_device, buffer, buffer_size,
             htc_device->endpoints.ctrl_endpoint);
         if (rc != EOK) {
@@ -312 +312 @@
  *
  */
-static int htc_config_credits(htc_device_t *htc_device)
+static errno_t htc_config_credits(htc_device_t *htc_device)
 {
         size_t buffer_size = sizeof(htc_frame_header_t) +
@@ -327 +327 @@
         
         /* Send HTC message. */
-        int rc = htc_send_control_message(htc_device, buffer, buffer_size,
+        errno_t rc = htc_send_control_message(htc_device, buffer, buffer_size,
             htc_device->endpoints.ctrl_endpoint);
         if (rc != EOK) {
@@ -360 +360 @@
  *
  */
-static int htc_complete_setup(htc_device_t *htc_device)
+static errno_t htc_complete_setup(htc_device_t *htc_device)
 {
         size_t buffer_size = sizeof(htc_frame_header_t) +
@@ -373 +373 @@
         
         /* Send HTC message. */
-        int rc = htc_send_control_message(htc_device, buffer, buffer_size,
+        errno_t rc = htc_send_control_message(htc_device, buffer, buffer_size,
             htc_device->endpoints.ctrl_endpoint);
         if (rc != EOK)
@@ -394 +394 @@
  *
  */
-static int htc_check_ready(htc_device_t *htc_device)
+static errno_t htc_check_ready(htc_device_t *htc_device)
 {
         size_t buffer_size = htc_device->ath_device->ctrl_response_length;
@@ -400 +400 @@
         
         /* Read response from device. */
-        int rc = htc_read_control_message(htc_device, buffer, buffer_size,
+        errno_t rc = htc_read_control_message(htc_device, buffer, buffer_size,
             NULL);
         if (rc != EOK) {
@@ -430 +430 @@
  *
  */
-int htc_device_init(ath_t *ath_device, ieee80211_dev_t *ieee80211_dev,
+errno_t htc_device_init(ath_t *ath_device, ieee80211_dev_t *ieee80211_dev,
     htc_device_t *htc_device)
 {
@@ -451 +451 @@
  *
  */
-int htc_init(htc_device_t *htc_device)
+errno_t htc_init(htc_device_t *htc_device)
 {
         /* First check ready message in device. */
-        int rc = htc_check_ready(htc_device);
+        errno_t rc = htc_check_ready(htc_device);
         if (rc != EOK) {
                 usb_log_error("Device is not in ready state after loading "