Changeset b7fd2a0 in mainline for uspace/lib/bithenge/src/failure.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/bithenge/src/failure.c (modified) (6 diffs)

uspace/lib/bithenge/src/failure.c

@@ -85 +85 @@
 {
         g_initialized = 1;
-        int rc = atexit(atexit_handler);
+        errno_t rc = atexit(atexit_handler);
         if (rc)
                 exit(127);
@@ -96 +96 @@
 /* Record a hit for a backtrace address and return whether this is the first
  * hit. */
-static inline int backtrace_item_hit(void *addr)
+static inline errno_t backtrace_item_hit(void *addr)
 {
         backtrace_item_t **bip;
@@ -120 +120 @@
 }
 
-int bithenge_should_fail(void)
+errno_t bithenge_should_fail(void)
 {
         g_failure_index++;
@@ -202 +202 @@
 }
 
-int bithenge_failure_ferror(FILE *stream)
+errno_t bithenge_failure_ferror(FILE *stream)
 {
         if (bithenge_should_fail())
@@ -216 +216 @@
 }
 
-int bithenge_failure_open(const char *pathname, int flags)
+errno_t bithenge_failure_open(const char *pathname, int flags)
 {
         if (bithenge_should_fail()) {
@@ -225 +225 @@
 }
 
-int bithenge_failure_fstat(int fd, struct stat *buf)
+errno_t bithenge_failure_fstat(int fd, struct stat *buf)
 {
         if (bithenge_should_fail()) {