Changeset b7fd2a0 in mainline for uspace/lib/bithenge/src/source.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/bithenge/src/source.c (modified) (3 diffs)

uspace/lib/bithenge/src/source.c

@@ -58 +58 @@
 }
 
-static int blob_from_hex(bithenge_node_t **out, const char *hex)
+static errno_t blob_from_hex(bithenge_node_t **out, const char *hex)
 {
         size_t size = str_length(hex);
@@ -85 +85 @@
  * @param source Specifies the node to be created.
  * @return EOK on success or an error code from errno.h. */
-int bithenge_node_from_source(bithenge_node_t **out, const char *source)
+errno_t bithenge_node_from_source(bithenge_node_t **out, const char *source)
 {
         if (str_chr(source, ':')) {
@@ -95 +95 @@
                         // Example: block:bd/initrd
                         service_id_t service_id;
-                        int rc = loc_service_get_id(source + 6, &service_id, 0);
+                        errno_t rc = loc_service_get_id(source + 6, &service_id, 0);
                         if (rc != EOK)
                                 return rc;