Changeset b7fd2a0 in mainline for uspace/lib/c/generic/fibril_synch.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/fibril_synch.c (modified) (3 diffs)

uspace/lib/c/generic/fibril_synch.c

@@ -352 +352 @@
 }
 
-int
+errno_t
 fibril_condvar_wait_timeout(fibril_condvar_t *fcv, fibril_mutex_t *fm,
     suseconds_t timeout)
@@ -392 +392 @@
 void fibril_condvar_wait(fibril_condvar_t *fcv, fibril_mutex_t *fm)
 {
-        int rc;
+        errno_t rc;
 
         rc = fibril_condvar_wait_timeout(fcv, fm, 0);
@@ -434 +434 @@
  * @param arg   Timer
  */
-static int fibril_timer_func(void *arg)
+static errno_t fibril_timer_func(void *arg)
 {
         fibril_timer_t *timer = (fibril_timer_t *) arg;
-        int rc;
+        errno_t rc;
 
         fibril_mutex_lock(timer->lockp);