Changeset b7fd2a0 in mainline for uspace/lib/c/generic/irq.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/irq.c (modified) (3 diffs)

uspace/lib/c/generic/irq.c

@@ -63 +63 @@
  *
  */
-int ipc_irq_subscribe(int inr, sysarg_t method, const irq_code_t *ucode,
+errno_t ipc_irq_subscribe(int inr, sysarg_t method, const irq_code_t *ucode,
     cap_handle_t *out_handle)
 {
@@ -69 +69 @@
                 ucode = &default_ucode;
         
-        return (int) __SYSCALL4(SYS_IPC_IRQ_SUBSCRIBE, inr, method, (sysarg_t) ucode,
+        return (errno_t) __SYSCALL4(SYS_IPC_IRQ_SUBSCRIBE, inr, method, (sysarg_t) ucode,
             (sysarg_t) out_handle);
 }
@@ -80 +80 @@
  *
  */
-int ipc_irq_unsubscribe(cap_handle_t cap)
+errno_t ipc_irq_unsubscribe(cap_handle_t cap)
 {
-        return (int) __SYSCALL1(SYS_IPC_IRQ_UNSUBSCRIBE, cap);
+        return (errno_t) __SYSCALL1(SYS_IPC_IRQ_UNSUBSCRIBE, cap);
 }