Changeset b7fd2a0 in mainline for uspace/lib/c/generic/ns.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/c/generic/ns.c (modified) (6 diffs)

uspace/lib/c/generic/ns.c

@@ -46 +46 @@
 static async_sess_t *sess_ns = NULL;
 
-int service_register(service_t service)
+errno_t service_register(service_t service)
 {
-        int retval;
+        errno_t retval;
         ipc_call_t answer;
         
@@ -57 +57 @@
         async_exch_t *exch = async_exchange_begin(sess);
         aid_t req = async_send_1(exch, NS_REGISTER, service, &answer);
-        int rc = async_connect_to_me(exch, 0, service, 0);
+        errno_t rc = async_connect_to_me(exch, 0, service, 0);
         
         async_exchange_end(exch);
@@ -123 +123 @@
 
 
-int ns_ping(void)
+errno_t ns_ping(void)
 {
         async_sess_t *sess = ns_session_get();
@@ -130 +130 @@
         
         async_exch_t *exch = async_exchange_begin(sess);
-        int rc = async_req_0_0(exch, NS_PING);
+        errno_t rc = async_req_0_0(exch, NS_PING);
         async_exchange_end(exch);
         
@@ -136 +136 @@
 }
 
-int ns_intro(task_id_t id)
+errno_t ns_intro(task_id_t id)
 {
         async_exch_t *exch;
@@ -144 +144 @@
         
         exch = async_exchange_begin(sess);
-        int rc = async_req_2_0(exch, NS_ID_INTRO, LOWER32(id), UPPER32(id));
+        errno_t rc = async_req_2_0(exch, NS_ID_INTRO, LOWER32(id), UPPER32(id));
         async_exchange_end(exch);