Changeset b7fd2a0 in mainline for uspace/lib/clui/nchoice.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/clui/nchoice.c (modified) (4 diffs)

uspace/lib/clui/nchoice.c

@@ -43 +43 @@
  *
  */
-int nchoice_create(nchoice_t **rchoice)
+errno_t nchoice_create(nchoice_t **rchoice)
 {
         nchoice_t *choice = NULL;
-        int rc;
+        errno_t rc;
 
         choice = calloc(1, sizeof(nchoice_t));
@@ -82 +82 @@
 
 /** Set numerica choice prompt text */
-int nchoice_set_prompt(nchoice_t *choice, const char *prompt)
+errno_t nchoice_set_prompt(nchoice_t *choice, const char *prompt)
 {
         char *pstr;
@@ -96 +96 @@
 
 /** Add option to numerical choice */
-int nchoice_add(nchoice_t *choice, const char *opttext, void *arg,
+errno_t nchoice_add(nchoice_t *choice, const char *opttext, void *arg,
     nchoice_flag_t flags)
 {
@@ -127 +127 @@
 
 /** Get numerical choice from user */
-int nchoice_get(nchoice_t *choice, void **rarg)
+errno_t nchoice_get(nchoice_t *choice, void **rarg)
 {
         int i;
-        int rc;
+        errno_t rc;
         int ret;
         char *str;