Changeset b7fd2a0 in mainline for uspace/lib/drv/include/ahci_iface.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/drv/include/ahci_iface.h (modified) (1 diff)

uspace/lib/drv/include/ahci_iface.h

@@ -43 +43 @@
 extern async_sess_t* ahci_get_sess(devman_handle_t, char **);
 
-extern int ahci_get_sata_device_name(async_sess_t *, size_t, char *);
-extern int ahci_get_num_blocks(async_sess_t *, uint64_t *);
-extern int ahci_get_block_size(async_sess_t *, size_t *);
-extern int ahci_read_blocks(async_sess_t *, uint64_t, size_t, void *);
-extern int ahci_write_blocks(async_sess_t *, uint64_t, size_t, void *);
+extern errno_t ahci_get_sata_device_name(async_sess_t *, size_t, char *);
+extern errno_t ahci_get_num_blocks(async_sess_t *, uint64_t *);
+extern errno_t ahci_get_block_size(async_sess_t *, size_t *);
+extern errno_t ahci_read_blocks(async_sess_t *, uint64_t, size_t, void *);
+extern errno_t ahci_write_blocks(async_sess_t *, uint64_t, size_t, void *);
 
 /** AHCI device communication interface. */
 typedef struct {
-        int (*get_sata_device_name)(ddf_fun_t *, size_t, char *);
-        int (*get_num_blocks)(ddf_fun_t *, uint64_t *);
-        int (*get_block_size)(ddf_fun_t *, size_t *);
-        int (*read_blocks)(ddf_fun_t *, uint64_t, size_t, void *);
-        int (*write_blocks)(ddf_fun_t *, uint64_t, size_t, void *);
+        errno_t (*get_sata_device_name)(ddf_fun_t *, size_t, char *);
+        errno_t (*get_num_blocks)(ddf_fun_t *, uint64_t *);
+        errno_t (*get_block_size)(ddf_fun_t *, size_t *);
+        errno_t (*read_blocks)(ddf_fun_t *, uint64_t, size_t, void *);
+        errno_t (*write_blocks)(ddf_fun_t *, uint64_t, size_t, void *);
 } ahci_iface_t;