Changeset b7fd2a0 in mainline for uspace/lib/ext4/src/superblock.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/ext4/src/superblock.c (modified) (4 diffs)

uspace/lib/ext4/src/superblock.c

@@ -1127 +1127 @@
  *
  */
-int ext4_superblock_read_direct(service_id_t service_id, ext4_superblock_t **sb)
+errno_t ext4_superblock_read_direct(service_id_t service_id, ext4_superblock_t **sb)
 {
         /* Allocated memory for superblock structure */
@@ -1135 +1135 @@
         
         /* Read data from block device */
-        int rc = block_read_bytes_direct(service_id, EXT4_SUPERBLOCK_OFFSET,
+        errno_t rc = block_read_bytes_direct(service_id, EXT4_SUPERBLOCK_OFFSET,
             EXT4_SUPERBLOCK_SIZE, data);
         
@@ -1157 +1157 @@
  *
  */
-int ext4_superblock_write_direct(service_id_t service_id, ext4_superblock_t *sb)
+errno_t ext4_superblock_write_direct(service_id_t service_id, ext4_superblock_t *sb)
 {
         /* Load physical block size from block device */
         size_t phys_block_size;
-        int rc = block_get_bsize(service_id, &phys_block_size);
+        errno_t rc = block_get_bsize(service_id, &phys_block_size);
         if (rc != EOK)
                 return rc;
@@ -1199 +1199 @@
  *
  */
-int ext4_superblock_check_sanity(ext4_superblock_t *sb)
+errno_t ext4_superblock_check_sanity(ext4_superblock_t *sb)
 {
         if (ext4_superblock_get_magic(sb) != EXT4_SUPERBLOCK_MAGIC)