Changeset b7fd2a0 in mainline for uspace/lib/fs/libfs.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/fs/libfs.h (modified) (4 diffs)

uspace/lib/fs/libfs.h

@@ -43 +43 @@
 
 typedef struct {
-        int (* fsprobe)(service_id_t, vfs_fs_probe_info_t *);
-        int (* mounted)(service_id_t, const char *, fs_index_t *, aoff64_t *);
-        int (* unmounted)(service_id_t);
-        int (* read)(service_id_t, fs_index_t, aoff64_t, size_t *);
-        int (* write)(service_id_t, fs_index_t, aoff64_t, size_t *,
+        errno_t (* fsprobe)(service_id_t, vfs_fs_probe_info_t *);
+        errno_t (* mounted)(service_id_t, const char *, fs_index_t *, aoff64_t *);
+        errno_t (* unmounted)(service_id_t);
+        errno_t (* read)(service_id_t, fs_index_t, aoff64_t, size_t *);
+        errno_t (* write)(service_id_t, fs_index_t, aoff64_t, size_t *,
             aoff64_t *);
-        int (* truncate)(service_id_t, fs_index_t, aoff64_t);
-        int (* close)(service_id_t, fs_index_t);
-        int (* destroy)(service_id_t, fs_index_t);
-        int (* sync)(service_id_t, fs_index_t);
+        errno_t (* truncate)(service_id_t, fs_index_t, aoff64_t);
+        errno_t (* close)(service_id_t, fs_index_t);
+        errno_t (* destroy)(service_id_t, fs_index_t);
+        errno_t (* sync)(service_id_t, fs_index_t);
 } vfs_out_ops_t;
 
@@ -65 +65 @@
          * argument holds the output argument.
          */
-        int (* root_get)(fs_node_t **, service_id_t);
-        int (* match)(fs_node_t **, fs_node_t *, const char *);
-        int (* node_get)(fs_node_t **, service_id_t, fs_index_t);
-        int (* node_open)(fs_node_t *);
-        int (* node_put)(fs_node_t *);
-        int (* create)(fs_node_t **, service_id_t, int);
-        int (* destroy)(fs_node_t *);
-        int (* link)(fs_node_t *, fs_node_t *, const char *);
-        int (* unlink)(fs_node_t *, fs_node_t *, const char *);
-        int (* has_children)(bool *, fs_node_t *);
+        errno_t (* root_get)(fs_node_t **, service_id_t);
+        errno_t (* match)(fs_node_t **, fs_node_t *, const char *);
+        errno_t (* node_get)(fs_node_t **, service_id_t, fs_index_t);
+        errno_t (* node_open)(fs_node_t *);
+        errno_t (* node_put)(fs_node_t *);
+        errno_t (* create)(fs_node_t **, service_id_t, int);
+        errno_t (* destroy)(fs_node_t *);
+        errno_t (* link)(fs_node_t *, fs_node_t *, const char *);
+        errno_t (* unlink)(fs_node_t *, fs_node_t *, const char *);
+        errno_t (* has_children)(bool *, fs_node_t *);
         /*
          * The second set of methods are usually mere getters that do not
@@ -85 +85 @@
         bool (* is_file)(fs_node_t *);
         service_id_t (* service_get)(fs_node_t *);
-        int (* size_block)(service_id_t, uint32_t *);
-        int (* total_block_count)(service_id_t, uint64_t *);
-        int (* free_block_count)(service_id_t, uint64_t *);
+        errno_t (* size_block)(service_id_t, uint32_t *);
+        errno_t (* total_block_count)(service_id_t, uint64_t *);
+        errno_t (* free_block_count)(service_id_t, uint64_t *);
 } libfs_ops_t;
 
@@ -95 +95 @@
 } fs_reg_t;
 
-extern int fs_register(async_sess_t *, vfs_info_t *, vfs_out_ops_t *,
+extern errno_t fs_register(async_sess_t *, vfs_info_t *, vfs_out_ops_t *,
     libfs_ops_t *);
 
 extern void fs_node_initialize(fs_node_t *);
 
-extern int fs_instance_create(service_id_t, void *);
-extern int fs_instance_get(service_id_t, void **);
-extern int fs_instance_destroy(service_id_t);
+extern errno_t fs_instance_create(service_id_t, void *);
+extern errno_t fs_instance_get(service_id_t, void **);
+extern errno_t fs_instance_destroy(service_id_t);
 
 #endif