Changeset b7fd2a0 in mainline for uspace/lib/ieee80211/src/ieee80211.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/ieee80211/src/ieee80211.c (modified) (18 diffs)

uspace/lib/ieee80211/src/ieee80211.c

@@ -496 +496 @@
 }
 
-static int ieee80211_scan(void *arg)
+static errno_t ieee80211_scan(void *arg)
 {
         assert(arg);
@@ -517 +517 @@
  *
  */
-static int ieee80211_open(ddf_fun_t *fun)
+static errno_t ieee80211_open(ddf_fun_t *fun)
 {
         nic_t *nic_data = nic_get_from_ddf_fun(fun);
@@ -527 +527 @@
         ieee80211_dev->started = true;
         
-        int rc = ieee80211_dev->ops->start(ieee80211_dev);
+        errno_t rc = ieee80211_dev->ops->start(ieee80211_dev);
         if (rc != EOK)
                 return rc;
@@ -655 +655 @@
  *
  */
-static int ieee80211_implement(ieee80211_dev_t *ieee80211_dev,
+static errno_t ieee80211_implement(ieee80211_dev_t *ieee80211_dev,
     ieee80211_ops_t *ieee80211_ops, ieee80211_iface_t *ieee80211_iface,
     nic_iface_t *nic_iface, ddf_dev_ops_t *nic_dev_ops)
@@ -731 +731 @@
  *
  */
-int ieee80211_device_init(ieee80211_dev_t *ieee80211_dev, ddf_dev_t *ddf_dev)
+errno_t ieee80211_device_init(ieee80211_dev_t *ieee80211_dev, ddf_dev_t *ddf_dev)
 {
         ieee80211_dev->ddf_dev = ddf_dev;
@@ -771 +771 @@
  *
  */
-int ieee80211_init(ieee80211_dev_t *ieee80211_dev,
+errno_t ieee80211_init(ieee80211_dev_t *ieee80211_dev,
     ieee80211_ops_t *ieee80211_ops, ieee80211_iface_t *ieee80211_iface,
     nic_iface_t *ieee80211_nic_iface, ddf_dev_ops_t *ieee80211_nic_dev_ops)
 {
-        int rc = ieee80211_implement(ieee80211_dev,
+        errno_t rc = ieee80211_implement(ieee80211_dev,
             ieee80211_ops, ieee80211_iface,
             ieee80211_nic_iface, ieee80211_nic_dev_ops);
@@ -850 +850 @@
  *
  */
-int ieee80211_probe_request(ieee80211_dev_t *ieee80211_dev, char *ssid)
+errno_t ieee80211_probe_request(ieee80211_dev_t *ieee80211_dev, char *ssid)
 {
         nic_t *nic = nic_get_from_ddf_dev(ieee80211_dev->ddf_dev);
@@ -917 +917 @@
  *
  */
-int ieee80211_authenticate(ieee80211_dev_t *ieee80211_dev)
+errno_t ieee80211_authenticate(ieee80211_dev_t *ieee80211_dev)
 {
         nic_t *nic = nic_get_from_ddf_dev(ieee80211_dev->ddf_dev);
@@ -967 +967 @@
  *
  */
-int ieee80211_associate(ieee80211_dev_t *ieee80211_dev, char *password)
+errno_t ieee80211_associate(ieee80211_dev_t *ieee80211_dev, char *password)
 {
         nic_t *nic = nic_get_from_ddf_dev(ieee80211_dev->ddf_dev);
@@ -1057 +1057 @@
  *
  */
-int ieee80211_deauthenticate(ieee80211_dev_t *ieee80211_dev)
+errno_t ieee80211_deauthenticate(ieee80211_dev_t *ieee80211_dev)
 {
         ieee80211_scan_result_t *auth_data =
@@ -1241 +1241 @@
  *
  */
-static int ieee80211_process_probe_response(ieee80211_dev_t *ieee80211_dev,
+static errno_t ieee80211_process_probe_response(ieee80211_dev_t *ieee80211_dev,
     ieee80211_mgmt_header_t *mgmt_header, size_t buffer_size)
 {
@@ -1327 +1327 @@
  *
  */
-static int ieee80211_process_auth_response(ieee80211_dev_t *ieee80211_dev,
+static errno_t ieee80211_process_auth_response(ieee80211_dev_t *ieee80211_dev,
     ieee80211_mgmt_header_t *mgmt_header)
 {
@@ -1356 +1356 @@
  *
  */
-static int ieee80211_process_assoc_response(ieee80211_dev_t *ieee80211_dev,
+static errno_t ieee80211_process_assoc_response(ieee80211_dev_t *ieee80211_dev,
     ieee80211_mgmt_header_t *mgmt_header)
 {
@@ -1381 +1381 @@
 }
 
-static int ieee80211_process_4way_handshake(ieee80211_dev_t *ieee80211_dev,
+static errno_t ieee80211_process_4way_handshake(ieee80211_dev_t *ieee80211_dev,
     void *buffer, size_t buffer_size)
 {
@@ -1491 +1491 @@
                             (buffer + sizeof(ieee80211_eapol_key_frame_t));
                         
-                        int rc;
+                        errno_t rc;
                         uint8_t work_key[32];
                         
@@ -1610 +1610 @@
 }
 
-static int ieee80211_process_eapol_frame(ieee80211_dev_t *ieee80211_dev,
+static errno_t ieee80211_process_eapol_frame(ieee80211_dev_t *ieee80211_dev,
     void *buffer, size_t buffer_size)
 {
@@ -1632 +1632 @@
  *
  */
-static int ieee80211_process_data(ieee80211_dev_t *ieee80211_dev,
+static errno_t ieee80211_process_data(ieee80211_dev_t *ieee80211_dev,
     void *buffer, size_t buffer_size)
 {
@@ -1696 +1696 @@
  *
  */
-int ieee80211_rx_handler(ieee80211_dev_t *ieee80211_dev, void *buffer,
+errno_t ieee80211_rx_handler(ieee80211_dev_t *ieee80211_dev, void *buffer,
     size_t buffer_size)
 {