Changeset b7fd2a0 in mainline for uspace/lib/nic/src/nic_ev.c

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/nic/src/nic_ev.c (modified) (5 diffs)

uspace/lib/nic/src/nic_ev.c

@@ -42 +42 @@
 
 /** Device address changed. */
-int nic_ev_addr_changed(async_sess_t *sess, const nic_address_t *addr)
+errno_t nic_ev_addr_changed(async_sess_t *sess, const nic_address_t *addr)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -48 +48 @@
         ipc_call_t answer;
         aid_t req = async_send_0(exch, NIC_EV_ADDR_CHANGED, &answer);
-        int retval = async_data_write_start(exch, addr,
+        errno_t retval = async_data_write_start(exch, addr,
             sizeof(nic_address_t));
 
@@ -63 +63 @@
 
 /** Device state changed. */
-int nic_ev_device_state(async_sess_t *sess, sysarg_t state)
+errno_t nic_ev_device_state(async_sess_t *sess, sysarg_t state)
 {
-        int rc;
+        errno_t rc;
 
         async_exch_t *exch = async_exchange_begin(sess);
@@ -75 +75 @@
 
 /** Frame received. */
-int nic_ev_received(async_sess_t *sess, void *data, size_t size)
+errno_t nic_ev_received(async_sess_t *sess, void *data, size_t size)
 {
         async_exch_t *exch = async_exchange_begin(sess);
@@ -81 +81 @@
         ipc_call_t answer;
         aid_t req = async_send_0(exch, NIC_EV_RECEIVED, &answer);
-        int retval = async_data_write_start(exch, data, size);
+        errno_t retval = async_data_write_start(exch, data, size);
 
         async_exchange_end(exch);