Changeset b7fd2a0 in mainline for uspace/lib/usbdev/include/usb/dev/pipes.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbdev/include/usb/dev/pipes.h (modified) (1 diff)

uspace/lib/usbdev/include/usb/dev/pipes.h

@@ -109 +109 @@
 } usb_endpoint_mapping_t;
 
-int usb_pipe_initialize(usb_pipe_t *, usb_endpoint_t, usb_transfer_type_t,
+errno_t usb_pipe_initialize(usb_pipe_t *, usb_endpoint_t, usb_transfer_type_t,
     size_t, usb_direction_t, unsigned, usb_dev_session_t *);
-int usb_pipe_initialize_default_control(usb_pipe_t *, usb_dev_session_t *);
+errno_t usb_pipe_initialize_default_control(usb_pipe_t *, usb_dev_session_t *);
 
-int usb_pipe_probe_default_control(usb_pipe_t *);
-int usb_pipe_initialize_from_configuration(usb_endpoint_mapping_t *,
+errno_t usb_pipe_probe_default_control(usb_pipe_t *);
+errno_t usb_pipe_initialize_from_configuration(usb_endpoint_mapping_t *,
     size_t, const uint8_t *, size_t, usb_dev_session_t *);
 
-int usb_pipe_register(usb_pipe_t *, unsigned);
-int usb_pipe_unregister(usb_pipe_t *);
+errno_t usb_pipe_register(usb_pipe_t *, unsigned);
+errno_t usb_pipe_unregister(usb_pipe_t *);
 
-int usb_pipe_read(usb_pipe_t *, void *, size_t, size_t *);
-int usb_pipe_write(usb_pipe_t *, const void *, size_t);
+errno_t usb_pipe_read(usb_pipe_t *, void *, size_t, size_t *);
+errno_t usb_pipe_write(usb_pipe_t *, const void *, size_t);
 
-int usb_pipe_control_read(usb_pipe_t *, const void *, size_t,
+errno_t usb_pipe_control_read(usb_pipe_t *, const void *, size_t,
     void *, size_t, size_t *);
-int usb_pipe_control_write(usb_pipe_t *, const void *, size_t,
+errno_t usb_pipe_control_write(usb_pipe_t *, const void *, size_t,
     const void *, size_t);