Changeset b7fd2a0 in mainline for uspace/lib/usbdev/include/usb/dev/request.h

Timestamp:

2018-01-13T03:10:29Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a53ed3a

Parents:

36f0738

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

Although this is a massive commit, it is a simple text replacement, and thus
is very easy to verify. Simply do the following:

`
git checkout <this commit's hash>
git reset HEAD
<sup>git add .
tools/srepl '\berrno_t\b' int
git add .
tools/srepl '\bsys_errno_t\b' sysarg_t
git reset
git diff
`</sup>

While this doesn't ensure that the replacements are correct, it does ensure
that the commit doesn't do anything except those replacements. Since errno_t
is typedef'd to int in the usual case (and sys_errno_t to sysarg_t), even if
incorrect, this commit cannot change behavior.

File:

• uspace/lib/usbdev/include/usb/dev/request.h (modified) (1 diff)

uspace/lib/usbdev/include/usb/dev/request.h

@@ -44 +44 @@
 #include <usb/request.h>
 
-int usb_control_request_set(usb_pipe_t *,
+errno_t usb_control_request_set(usb_pipe_t *,
     usb_request_type_t, usb_request_recipient_t, uint8_t,
     uint16_t, uint16_t, const void *, size_t);
 
-int usb_control_request_get(usb_pipe_t *,
+errno_t usb_control_request_get(usb_pipe_t *,
     usb_request_type_t, usb_request_recipient_t, uint8_t,
     uint16_t, uint16_t, void *, size_t, size_t *);
 
-int usb_request_get_status(usb_pipe_t *, usb_request_recipient_t,
+errno_t usb_request_get_status(usb_pipe_t *, usb_request_recipient_t,
     uint16_t, uint16_t *);
-int usb_request_clear_feature(usb_pipe_t *, usb_request_type_t,
+errno_t usb_request_clear_feature(usb_pipe_t *, usb_request_type_t,
     usb_request_recipient_t, uint16_t, uint16_t);
-int usb_request_set_feature(usb_pipe_t *, usb_request_type_t,
+errno_t usb_request_set_feature(usb_pipe_t *, usb_request_type_t,
     usb_request_recipient_t, uint16_t, uint16_t);
-int usb_request_get_descriptor(usb_pipe_t *, usb_request_type_t,
+errno_t usb_request_get_descriptor(usb_pipe_t *, usb_request_type_t,
     usb_request_recipient_t, uint8_t, uint8_t, uint16_t, void *, size_t,
     size_t *);
-int usb_request_get_descriptor_alloc(usb_pipe_t *, usb_request_type_t,
+errno_t usb_request_get_descriptor_alloc(usb_pipe_t *, usb_request_type_t,
     usb_request_recipient_t, uint8_t, uint8_t, uint16_t, void **, size_t *);
-int usb_request_get_device_descriptor(usb_pipe_t *,
+errno_t usb_request_get_device_descriptor(usb_pipe_t *,
     usb_standard_device_descriptor_t *);
-int usb_request_get_bare_configuration_descriptor(usb_pipe_t *, int,
+errno_t usb_request_get_bare_configuration_descriptor(usb_pipe_t *, int,
     usb_standard_configuration_descriptor_t *);
-int usb_request_get_full_configuration_descriptor(usb_pipe_t *, int,
+errno_t usb_request_get_full_configuration_descriptor(usb_pipe_t *, int,
     void *, size_t, size_t *);
-int usb_request_get_full_configuration_descriptor_alloc(usb_pipe_t *,
+errno_t usb_request_get_full_configuration_descriptor_alloc(usb_pipe_t *,
     int, const void **, size_t *);
-int usb_request_set_descriptor(usb_pipe_t *, usb_request_type_t,
+errno_t usb_request_set_descriptor(usb_pipe_t *, usb_request_type_t,
     usb_request_recipient_t, uint8_t, uint8_t, uint16_t, const void *, size_t);
 
-int usb_request_get_configuration(usb_pipe_t *, uint8_t *);
-int usb_request_set_configuration(usb_pipe_t *, uint8_t);
+errno_t usb_request_get_configuration(usb_pipe_t *, uint8_t *);
+errno_t usb_request_set_configuration(usb_pipe_t *, uint8_t);
 
-int usb_request_get_interface(usb_pipe_t *, uint8_t, uint8_t *);
-int usb_request_set_interface(usb_pipe_t *, uint8_t, uint8_t);
+errno_t usb_request_get_interface(usb_pipe_t *, uint8_t, uint8_t *);
+errno_t usb_request_set_interface(usb_pipe_t *, uint8_t, uint8_t);
 
-int usb_request_get_supported_languages(usb_pipe_t *,
+errno_t usb_request_get_supported_languages(usb_pipe_t *,
     l18_win_locales_t **, size_t *);
-int usb_request_get_string(usb_pipe_t *, size_t, l18_win_locales_t,
+errno_t usb_request_get_string(usb_pipe_t *, size_t, l18_win_locales_t,
     char **);
 
-int usb_request_clear_endpoint_halt(usb_pipe_t *, uint16_t);
-int usb_pipe_clear_halt(usb_pipe_t *, usb_pipe_t *);
-int usb_request_get_endpoint_status(usb_pipe_t *, usb_pipe_t *, uint16_t *);
+errno_t usb_request_clear_endpoint_halt(usb_pipe_t *, uint16_t);
+errno_t usb_pipe_clear_halt(usb_pipe_t *, usb_pipe_t *);
+errno_t usb_request_get_endpoint_status(usb_pipe_t *, usb_pipe_t *, uint16_t *);
 
 #endif